You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "janl (via GitHub)" <gi...@apache.org> on 2024/10/22 09:31:38 UTC
[PR] feat: add 3.4.2 and 3.4.2-nouveau [couchdb-docker]
janl opened a new pull request, #273:
URL: https://github.com/apache/couchdb-docker/pull/273
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add 3.4.2 and 3.4.2-nouveau [couchdb-docker]
Posted by "janl (via GitHub)" <gi...@apache.org>.
janl commented on code in PR #273:
URL: https://github.com/apache/couchdb-docker/pull/273#discussion_r1810461470
##########
3.4.2-nouveau/Dockerfile:
##########
@@ -0,0 +1,88 @@
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License. You may obtain a copy of
+# the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations under
+# the License.
+
+FROM debian:bookworm-slim
+
+LABEL maintainer="CouchDB Developers dev@couchdb.apache.org"
+
+# Add CouchDB user account to make sure the IDs are assigned consistently
+RUN groupadd -g 5984 -r nouveau && useradd -u 5984 -d /opt/nouveau -g nouveau nouveau
+
+# be sure GPG and apt-transport-https are available and functional
+RUN set -ex; \
Review Comment:
I would prefer we do this outside of a release cycle, making structural changes like this could lead to delayed reviews on the official library, which we wanna avoid. 3.4.1 was a two week affair already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add 3.4.2 and 3.4.2-nouveau [couchdb-docker]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva merged PR #273:
URL: https://github.com/apache/couchdb-docker/pull/273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add 3.4.2 and 3.4.2-nouveau [couchdb-docker]
Posted by "rnewson (via GitHub)" <gi...@apache.org>.
rnewson commented on code in PR #273:
URL: https://github.com/apache/couchdb-docker/pull/273#discussion_r1810361208
##########
3.4.2-nouveau/Dockerfile:
##########
@@ -0,0 +1,88 @@
+# Licensed under the Apache License, Version 2.0 (the "License"); you may not
+# use this file except in compliance with the License. You may obtain a copy of
+# the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations under
+# the License.
+
+FROM debian:bookworm-slim
+
+LABEL maintainer="CouchDB Developers dev@couchdb.apache.org"
+
+# Add CouchDB user account to make sure the IDs are assigned consistently
+RUN groupadd -g 5984 -r nouveau && useradd -u 5984 -d /opt/nouveau -g nouveau nouveau
+
+# be sure GPG and apt-transport-https are available and functional
+RUN set -ex; \
Review Comment:
https://www.docker.com/blog/introduction-to-heredocs-in-dockerfiles/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add 3.4.2 and 3.4.2-nouveau [couchdb-docker]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #273:
URL: https://github.com/apache/couchdb-docker/pull/273#issuecomment-2430001247
buildx upload worked https://hub.docker.com/r/apache/couchdb/tags
Still need to do the `3` and `latest` but will merging the PR as those are aliases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: add 3.4.2 and 3.4.2-nouveau [couchdb-docker]
Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on PR #273:
URL: https://github.com/apache/couchdb-docker/pull/273#issuecomment-2429585116
Running `buildx...` with this PR, will report when complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org