You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/06/09 03:57:18 UTC
[GitHub] [iotdb] zhengjp31 opened a new pull request #3379: system design -edit
zhengjp31 opened a new pull request #3379:
URL: https://github.com/apache/iotdb/pull/3379
Correct English errors in the official website
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #3379: system design -edit
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #3379:
URL: https://github.com/apache/iotdb/pull/3379#discussion_r647990584
##########
File path: docs/SystemDesign/SchemaManager/SchemaManager.md
##########
@@ -173,7 +173,7 @@ The root node exists by default. Creating storage groups, deleting storage group
* create LeafMNode, and store the alias in LeafMNode if it has
* If it has alias, create another links with alias to LeafMNode
-* Deleting a storage group is similar to deleting a time series. That is, the storage group or time series node is deleted in its parent node. The time series node also needs to delete its alias in the parent node; if in the deletion process, a node is found not to have any child node, needs to be deleted recursively.
+* Deleting a storage group is similar to deleting a time series. That is, the storage group or time series node is deleted in its parent node. The time series node also needs to delete its alias in the parent node; If in the deletion process,it is found that a node does not any child nodes, it also needs to recursively delete this node.
Review comment:
```suggestion
* Deleting a storage group is similar to deleting a time series. That is, the storage group or time series node is deleted in its parent node. The time series node also needs to delete its alias in the parent node; If in the deletion process, it is found that a node does not have any child nodes, it also needs to delete this node recursively.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #3379: system design -edit
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #3379:
URL: https://github.com/apache/iotdb/pull/3379#discussion_r647989417
##########
File path: docs/SystemDesign/DataQuery/QueryFundamentals.md
##########
@@ -34,12 +34,12 @@ IoTDB stores sequential and un-sequential TsFiles separately under `data/sequenc
It should be noted that, in the following query documents, we tend to use `seq file` to represent Sequential files for short. For un-sequential ones we use `unseq file`. Sometimes `unordered file` or `out-of-order file` are also used as aliases of un-sequential files.
-## General query process
+## General process of reading TsFile
Review comment:
This part is not only introducing reading TsFile from disk, it also contains the process of reading memory data, which is not in TsFile yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #3379: system design -edit
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #3379:
URL: https://github.com/apache/iotdb/pull/3379#discussion_r647990584
##########
File path: docs/SystemDesign/SchemaManager/SchemaManager.md
##########
@@ -173,7 +173,7 @@ The root node exists by default. Creating storage groups, deleting storage group
* create LeafMNode, and store the alias in LeafMNode if it has
* If it has alias, create another links with alias to LeafMNode
-* Deleting a storage group is similar to deleting a time series. That is, the storage group or time series node is deleted in its parent node. The time series node also needs to delete its alias in the parent node; if in the deletion process, a node is found not to have any child node, needs to be deleted recursively.
+* Deleting a storage group is similar to deleting a time series. That is, the storage group or time series node is deleted in its parent node. The time series node also needs to delete its alias in the parent node; If in the deletion process,it is found that a node does not any child nodes, it also needs to recursively delete this node.
Review comment:
```suggestion
* Deleting a storage group is similar to deleting a time series. That is, the storage group or time series node is deleted in its parent node. The time series node also needs to delete its alias in the parent node; If in the deletion process, it is found that a node does not any child nodes, it also needs to recursively delete this node.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #3379: Update some English system design documents
Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #3379:
URL: https://github.com/apache/iotdb/pull/3379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org