[GitHub] [beam] chamikaramj commented on a change in pull request #11834: [BEAM-10117] Correct erroneous Job Failed message

[GitBox <gi...@apache.org>]

chamikaramj commented on a change in pull request #11834:
URL: https://github.com/apache/beam/pull/11834#discussion_r436891884



##########
File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java
##########
@@ -137,8 +137,8 @@ void waitForDone() throws Exception {
               throw e;
             }
           } else {
-            // Job failed, schedule it again.
-            LOG.info("Job {} failed. retrying.", jobInfo.pendingJob.currentJobId);
+            // Job not yet complete, schedule it again.

Review comment:
       Hmm, seems like pollJob() call usually returns false if the job failed.
   https://github.com/apache/beam/blob/2a4092dfb8c46408818402b1c4a09a8cd44e907a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryHelpers.java#L260




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org