You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/11 07:32:11 UTC
[GitHub] [skywalking] kezhenxu94 opened a new issue, #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
kezhenxu94 opened a new issue, #9762:
URL: https://github.com/apache/skywalking/issues/9762
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
In recent pull requests from @yswdqz we can monitor metrics from MySQL and PostgreSQL, but currently we assume that every MySQL/PostgreSQL server only has one instance, and we use that instance as the service name, (refer to our demo environment http://demo.skywalking.apache.org/mySQL)
<img width="1182" alt="image" src="https://user-images.githubusercontent.com/15965696/195023145-784519cb-af23-4736-b9dc-cdc87862f11d.png">
However, a MySQL/PostgreSQL server should be able to have multiple instances and form a cluster, in that case, we should have aggregated metrics for those instances.
### Use case
When there are multiple instances/nodes for one MySQL/PostgreSQL server, users can have an aggregated overview of the database server.
### Related issues
_No response_
### Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] yswdqz commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
yswdqz commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1281931690
To confirm, do I need to wait for the new pr to be submitted or temporarily set slowsql to service level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1306575664
> For now instance level Slow Statements is not supported.
Do you mean UI component doesn't support instance level Slow Statement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1281967682
> temporarily set slowsql to service level?
This should be good enough for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] yswdqz commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
yswdqz commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1306569093
For now instance level Slow Statements is not supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1306585324
> > > temporarily set slowsql to service level?
> >
> >
> > This should be good enough for now.
>
> It is not supported by LAL slow sql spec, too. I used to think the service level was enough. If it is needed, I can change the LAL part.
OK, let's only support service level for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1274231729
@yswdqz I think we could have perf of both k8s service and per pod(as skywalking instance level).
We had a similar discussion with @pg-yang from https://github.com/apache/skywalking-showcase/pull/83#issuecomment-1272504487. Generally about the same preferences.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] yswdqz commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
yswdqz commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1274232803
Yes, I will.
But I am doing another PR now, might be doing this later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
URL: https://github.com/apache/skywalking/issues/9762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1274245077
If you mean the SQL-sign, I think you don't need to hurry. After all, I could image that is a long-term feature, we may face forward and backward several times, also be struggling due to the tradeoff :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1280307175
I think we only support slow SQL at service for now.
I just talked with @mrproliu about extending sampled records for various entity level, even for relationship.
FYI @Fine0830 We may need to adjust sampled record widget as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] yswdqz commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
yswdqz commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1306579194
> > temporarily set slowsql to service level?
>
> This should be good enough for now.
It is not supported by LAL slow sql spec, too. I used to think the service level was enough. If it is needed, I can change the LAL part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] yswdqz commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
yswdqz commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1274246792
> If you mean the SQL-sign, I think you don't need to hurry. After all, I could image that is a long-term feature, we may face forward and backward several times, also be struggling due to the tradeoff :)
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1274220864
@yswdqz I can't assign this to you YET, are you willing to continue this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1279735121
@yswdqz How is this going?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1306564699
> And I remove the instance level's Slow Statement. Now Slow Statement only exist in service level.
Hi, why do you think we should remove Slow Statements in instance level?
The other screenshots looks good to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1280098674
> I am comfused about which metrics should I to set for cluster because there are many kind of cluster (such as galera, MMM) and It's hard to find good metrics/exporter for most of them.
>
> And is this issue ("have an aggregated overview of the database server") means that I just need to set service lever dashboards the same as instance level?
The service name should be set by users in a label `service`. Usually they should set this to the business usage such as `product1`, `product2`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] yswdqz commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
yswdqz commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1280006106
I am comfused about which metrics should I to set for cluster because there are many kind of cluster (such as galera, MMM) and It's hard to find good metrics/exporter for most of them.
And is this issue ("have an aggregated overview of the database server") means that I just need to set service lever dashboards the same as instance level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1280129191
About which metrics, I think there would not have much difference. When you set up a MySQL service in prod env, usually there is read/write or master/slave deployment for a database to provide HA or higher performance.
This is generally why Zhenxu asked you to monitoring MySQL from a service perspective rather than currently from a single MySQL node(instance) perspective.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] yswdqz commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
yswdqz commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1280301601
> About which metrics, I think there would not have much difference. When you set up a MySQL service in prod env, usually there is read/write or master/slave deployment for a database to provide HA or higher performance. This is generally why Zhenxu asked you to monitoring MySQL from a service perspective rather than currently from a single MySQL node(instance) perspective.
So the slow sql monitoring should be service level(not instance level)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] yswdqz commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
yswdqz commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1281968955
> > temporarily set slowsql to service level?
>
> This should be good enough for now.
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] yswdqz commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
yswdqz commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1279747733
> @yswdqz How is this going?
I haven't started it yet ( because of something about my university ). I will start it tomorrow.
By the way, Does this mean that I should set what I previously set as `service` to `instance` and then set the cluster's metrics to `service`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1279748962
Yes, each IP/pod should be an instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] yswdqz commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
yswdqz commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1279749559
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] yswdqz commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
yswdqz commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1305091244
MySQL - Service:
MySQL - Instance:
Is that ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] yswdqz commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
yswdqz commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1282508553
This is the service level design. Is that OK ?
Inspections : show metrics
Slow Stetement: shiow slowsql statements;
Instances: show instances of this service.
And I remove the instance level's Slow Statement. Now Slow Statement only exist in service level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #9762: MySQL/PostgreSQL monitor should be able to support cluster mode scenario
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #9762:
URL: https://github.com/apache/skywalking/issues/9762#issuecomment-1282549639
Make sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org