You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/11 21:53:54 UTC
[GitHub] [superset] hughhhh commented on a diff in pull request #19653: feat: Create new `ModelRESTApi` for sip-68 models read-only
hughhhh commented on code in PR #19653:
URL: https://github.com/apache/superset/pull/19653#discussion_r847765650
##########
superset/datasets/models.py:
##########
@@ -90,3 +92,79 @@ class Dataset(Model, AuditMixinNullable, ExtraJSONMixin, ImportExportMixin):
# Column is managed externally and should be read-only inside Superset
is_managed_externally = sa.Column(sa.Boolean, nullable=False, default=False)
external_url = sa.Column(sa.Text, nullable=True)
+
+ # todo(hugh): Figure how to use this field and populate
+ # default_schema = Column()
+
+ # String representing the permissions for a given dataset
+ # todo(hugh): compute these columns based upon the original SqlaTable models
+ # perm = column_property(name)
+ schema = column_property()
+
+ """
+ Legacy Properties used to main backwards compatibility for
+ the current API schema
+ """
+
+ @property
+ def datasource_type(self) -> Optional[str]:
+ return self.__tablename__
+
+ @property
+ def kind(self) -> Optional[str]:
+ # https://github.com/apache/superset/blob/79a7a5d1b1682f79f1aab1723f76a34dcb9bf030/superset/connectors/base/models.py#L121
+ return "virtual" if self.is_physical else "physical"
+
+ @property
+ def schema(self) -> Optional[str]:
+ return "public"
+
+ @property
+ def sql(self) -> Optional[str]:
+ return self.expression
+
+ @property
+ def table_name(self) -> Optional[str]:
+ return self.name
+
+ @property
+ def explore_url(self) -> Optional[str]:
+ return f"/superset/explore/{self.type}/{self.id}/"
+
+ @property
+ def changed_by_url(self) -> Optional[str]:
+ return "todo"
+
+ @property
+ def default_endpoint(self) -> Optional[str]:
+ return "todo"
+
+ @property
+ def description(self) -> Optional[str]:
+ return "todo"
+
+ @property
+ def database(self) -> Optional[Dict[str, Any]]:
Review Comment:
remove these since we can access tables
##########
superset/datasets/models.py:
##########
@@ -90,3 +92,79 @@ class Dataset(Model, AuditMixinNullable, ExtraJSONMixin, ImportExportMixin):
# Column is managed externally and should be read-only inside Superset
is_managed_externally = sa.Column(sa.Boolean, nullable=False, default=False)
external_url = sa.Column(sa.Text, nullable=True)
+
+ # todo(hugh): Figure how to use this field and populate
+ # default_schema = Column()
+
+ # String representing the permissions for a given dataset
+ # todo(hugh): compute these columns based upon the original SqlaTable models
+ # perm = column_property(name)
+ schema = column_property()
+
+ """
+ Legacy Properties used to main backwards compatibility for
+ the current API schema
+ """
+
+ @property
+ def datasource_type(self) -> Optional[str]:
+ return self.__tablename__
+
+ @property
+ def kind(self) -> Optional[str]:
+ # https://github.com/apache/superset/blob/79a7a5d1b1682f79f1aab1723f76a34dcb9bf030/superset/connectors/base/models.py#L121
+ return "virtual" if self.is_physical else "physical"
+
+ @property
+ def schema(self) -> Optional[str]:
+ return "public"
+
+ @property
+ def sql(self) -> Optional[str]:
+ return self.expression
+
+ @property
+ def table_name(self) -> Optional[str]:
+ return self.name
+
+ @property
+ def explore_url(self) -> Optional[str]:
+ return f"/superset/explore/{self.type}/{self.id}/"
+
+ @property
+ def changed_by_url(self) -> Optional[str]:
+ return "todo"
+
+ @property
+ def default_endpoint(self) -> Optional[str]:
+ return "todo"
+
+ @property
+ def description(self) -> Optional[str]:
+ return "todo"
+
+ @property
+ def database(self) -> Optional[Dict[str, Any]]:
+ if self.tables:
+ database = (
+ db.session.query(Database)
+ .filter(Database.id == self.tables[0].database_id)
+ .one()
+ )
+ return database.data
+ return None
+
+ @property
+ def schema(self) -> Optional[str]:
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org