You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tamas Mate (Code Review)" <ge...@cloudera.org> on 2022/08/11 14:55:46 UTC
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Tamas Mate has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18838
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
......................................................................
IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
This commit documents the Iceberg expire snapshot functionality.
Testing:
- Built the docs locally and verified the generated html.
Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
---
M docs/topics/impala_iceberg.xml
1 file changed, 24 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/18838/1
--
To view, visit http://gerrit.cloudera.org:8080/18838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Doc is very clear now, thanks.
LGTM conditional on one more spelling fix, please carry the +2 forward
http://gerrit.cloudera.org:8080/#/c/18838/2/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/18838/2/docs/topics/impala_iceberg.xml@535
PS2, Line 535: allows automatic metadata file removal after operations that modify metada such as
Spelling: "modify metadata"
--
To view, visit http://gerrit.cloudera.org:8080/18838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 18:56:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
......................................................................
Patch Set 3: Code-Review+2
Thank you for the review Andrew and Gergely!
Carrying forward the +2.
--
To view, visit http://gerrit.cloudera.org:8080/18838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 10:02:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Hello Andrew Sherman, Gabor Kaszab, Zoltan Borok-Nagy, Gergely Fürnstáhl, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/18838
to look at the new patch set (#3).
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
......................................................................
IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
This commit documents the Iceberg expire snapshot functionality.
Testing:
- Built the docs locally and verified the generated html.
Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
---
M docs/topics/impala_iceberg.xml
1 file changed, 32 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/18838/3
--
To view, visit http://gerrit.cloudera.org:8080/18838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/664/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/18838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 14:55:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
......................................................................
Patch Set 1:
(4 comments)
Thank you for the review Andrew and Gergely. Updated the change.
http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@513
PS1, Line 513: Iceberg snapshots accumulate until they are expired
> This does not feel quite right. It suggests that the accumulation stops on
Done
http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@525
PS1, Line 525: <li>does not remove orphanned data files.</li>
> Spelling: "orphaned"
Done
http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@526
PS1, Line 526: minumum snapshots
> I think minimum should refer to the quantity in this case
Done
http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@526
PS1, Line 526: <li>respects the minumum snapshots to keep:
> Spelling: "minimum"
Done
--
To view, visit http://gerrit.cloudera.org:8080/18838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Aug 2022 11:15:23 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
......................................................................
Patch Set 4: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 4
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 10:17:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/666/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/18838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Aug 2022 11:22:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/669/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/18838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 10:07:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/664/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/18838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 15:03:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
......................................................................
Patch Set 1:
(3 comments)
Quick comments...
http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@513
PS1, Line 513: Iceberg snapshots accumulate until they are expired. Snapshots can be expired wih
Expiration sounds like something that might happen automatically. I think we should make it clear that expiration is not automatic. We could say "until they are deleted by a user action. Snapshots can be deleted with", and then "which will delete snapshots".
This assumes that I am understanding how it works.
Spelling: "with"
http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@525
PS1, Line 525: <li>does not remove orphanned data files.</li>
Spelling: "orphaned"
http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@526
PS1, Line 526: <li>respects the minumum snapshots to keep:
Spelling: "minimum"
--
To view, visit http://gerrit.cloudera.org:8080/18838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Aug 2022 15:42:17 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Posted by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org>.
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml
File docs/topics/impala_iceberg.xml:
http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@513
PS1, Line 513: Iceberg snapshots accumulate until they are expired
This does not feel quite right. It suggests that the accumulation stops on expiration, which is not true. The snapshots stop to exist on expiration, the accumulation continues.
And I would use the vocabulary of the statement and then explain what it does.
Maybe the following is clearer:
"Iceberg snapshots accumulate indefinitely. Snapshots can be expired with ... which will delete snapshots older than ..."
http://gerrit.cloudera.org:8080/#/c/18838/1/docs/topics/impala_iceberg.xml@526
PS1, Line 526: minumum snapshots
I think minimum should refer to the quantity in this case
"minimum number of snapshots"
--
To view, visit http://gerrit.cloudera.org:8080/18838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 1
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 15 Aug 2022 10:06:48 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/666/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/18838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Aug 2022 11:15:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
......................................................................
IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
This commit documents the Iceberg expire snapshot functionality.
Testing:
- Built the docs locally and verified the generated html.
Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Reviewed-on: http://gerrit.cloudera.org:8080/18838
Reviewed-by: Tamas Mate <tm...@apache.org>
Tested-by: Tamas Mate <tm...@apache.org>
---
M docs/topics/impala_iceberg.xml
1 file changed, 32 insertions(+), 0 deletions(-)
Approvals:
Tamas Mate: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 5
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Posted by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org>.
Gergely Fürnstáhl has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
......................................................................
Patch Set 2: Code-Review+1
LGTM!
--
To view, visit http://gerrit.cloudera.org:8080/18838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 08:29:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/669/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/18838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 3
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 10:01:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
Posted by "Tamas Mate (Code Review)" <ge...@cloudera.org>.
Tamas Mate has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18838 )
Change subject: IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
......................................................................
IMPALA-11483: [DOCS] Document EXPIRE SNAPSHOTS functionality
This commit documents the Iceberg expire snapshot functionality.
Testing:
- Built the docs locally and verified the generated html.
Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
---
M docs/topics/impala_iceberg.xml
1 file changed, 32 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/18838/2
--
To view, visit http://gerrit.cloudera.org:8080/18838
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iddd927dd1b6ee3b99dd29982018a610389e64836
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 2
Gerrit-Owner: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>