[GitHub] [spark] ryan-johnson-databricks commented on a diff in pull request #37879: [SPARK-40425][SQL] DROP TABLE does not need to do table lookup

["ryan-johnson-databricks (via GitHub)" <gi...@apache.org>]

ryan-johnson-databricks commented on code in PR #37879:
URL: https://github.com/apache/spark/pull/37879#discussion_r1171695600


##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -216,19 +216,23 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager)
         c
       }
 
-    case DropTable(ResolvedV1TableIdentifier(ident), ifExists, purge) =>
+    case DropTable(ResolvedV1Identifier(ident), ifExists, purge) =>

Review Comment:
   > catalogs can override `tableExists` and that would be cheaper than `loadTable`?
   
   Once you make an RPC, the latency hit is there. I would expect that exists vs. load on the backend would be a distant second.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org