You are viewing a plain text version of this content. The canonical link for it is here.
Posted to c-dev@xerces.apache.org by "Roger Leigh (JIRA)" <xe...@xml.apache.org> on 2018/02/15 13:44:00 UTC
[jira] [Commented] (XERCESC-2137) CMake Build Doesn't Activate
XERCES_MFC_SUPPORT
[ https://issues.apache.org/jira/browse/XERCESC-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16365536#comment-16365536 ]
Roger Leigh commented on XERCESC-2137:
--------------------------------------
The code in XMemory appears to be just stubs that delegate to operator new(size), and there are no callers in the tree. As far as I can tell, it's completely pointless and does nothing at all! We could likely delete them with no functional impact.
Did you need them for any specific purpose? I'm not an MFC expert; if there's a good reason to have this we can write the necessary CMake logic to detect MFC support is available and enable it. But if it's non-functional, we might be better removing it entirely?
> CMake Build Doesn't Activate XERCES_MFC_SUPPORT
> -----------------------------------------------
>
> Key: XERCESC-2137
> URL: https://issues.apache.org/jira/browse/XERCESC-2137
> Project: Xerces-C++
> Issue Type: Bug
> Components: Build
> Environment: MS Visual Studio
> Reporter: Scott Morgan
> Priority: Major
>
> The XERCES_MFC_SUPPORT define is needed for Visual Studio debug builds, it activates some code in XMemory.hpp/cpp
> Should just be a case of detecting MSVC in the main CMakeLists.txt and adding a '#cmakedefine XERCES_MFC_SUPPORT' line in Xerces_autoconf_config.hpp.cmake.in
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: c-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: c-dev-help@xerces.apache.org