You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/25 08:11:05 UTC
[GitHub] [apisix-dashboard] wmdmomo opened a new pull request #2001: feat(plugin): fix UI referer-restriction
wmdmomo opened a new pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [ ] New feature provided
- [x] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
The PR will change the plugin under plugin/UI (referer-restriction), allowing referer-restriction to dynamically adapt to the back-end json rules.
**Related issues**
fix/resolve #1588
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [x] Have you added corresponding test cases?
- [x] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #2001: feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#discussion_r677531465
##########
File path: web/src/components/Plugin/UI/referer-restriction.tsx
##########
@@ -86,7 +90,7 @@ const RefererRestriction: React.FC<Props> = ({ form }) => {
</Form.Item>
</Col>
<Col style={{ ...removeBtnStyle, marginLeft: -10 }}>
- {fields.length > 1 ? (
+ {fields.length > whiteMinLen ? (
Review comment:
```suggestion
{fields.length > allowListMinLength ? (
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] wmdmomo commented on pull request #2001: feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
wmdmomo commented on pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#issuecomment-923713924
@liuxiran Sorry to reply now. The referer-restriction test case has been completed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 merged pull request #2001: feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
bzp2010 merged pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #2001: feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
LiteSun commented on pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#issuecomment-902399314
> Test cases are needed to ensure the feature worked properly
When you have time, could you please help her with the steps of the test? @liuxiran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2001: feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#issuecomment-924060031
@wmdmomo The code looks good to me. But please pay attention to the errors in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #2001: feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#issuecomment-889548185
Test cases are needed to ensure the feature worked properly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #2001: feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#issuecomment-914932842
Hi @wmdmomo if you have any problem please let me know, thanks a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #2001: feat(plugin): fix UI referer-restriction
Posted by GitBox <gi...@apache.org>.
netlify[bot] commented on pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#issuecomment-886164393
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: 631f7b34402fdd5b5676da75bb16d849d47e9d76
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60fd1c8c19283b0008197cb7](https://app.netlify.com/sites/apisix-dashboard/deploys/60fd1c8c19283b0008197cb7?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2001: feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#issuecomment-886164393
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: d6e64f889bf32f6f6d09950ab903c29f4f8ec883
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610fdaa37f45c00008fe6b1a](https://app.netlify.com/sites/apisix-dashboard/deploys/610fdaa37f45c00008fe6b1a?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2001: feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#issuecomment-886164393
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: c11f0fb2c2c921cf3ff523e178fd021393188172
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6100214b9774020008d20c3d](https://app.netlify.com/sites/apisix-dashboard/deploys/6100214b9774020008d20c3d?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2001--apisix-dashboard.netlify.app/](https://deploy-preview-2001--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2001: feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#issuecomment-886164393
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: d6e64f889bf32f6f6d09950ab903c29f4f8ec883
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/610fdaa37f45c00008fe6b1a](https://app.netlify.com/sites/apisix-dashboard/deploys/610fdaa37f45c00008fe6b1a?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2001--apisix-dashboard.netlify.app/](https://deploy-preview-2001--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #2001: feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#issuecomment-914932842
Hi @wmdmomo if you have any problem please let us know, thanks a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on pull request #2001: feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
liuxiran commented on pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#issuecomment-902531803
> > Test cases are needed to ensure the feature worked properly
>
> When you have time, could you please help her with the steps of the test? @liuxiran
Ok, after check the current test case about referer-restriction form, @wmdmomo can try to add test cases to https://github.com/apache/apisix-dashboard/blob/master/web/cypress/integration/route/create-route-with-referer-restriction-form.spec.js,
1. enable `referer-restriction` plugin, check default white list item should be one, and there is no delete button behind it
2. test the white list input validate rule: input `apisix-dashboard_1.com` should be passed, and input `qq@` should be invalid,
3. default `bypass_missing` is disabled
4. add a white list item field, each of them should have delete button behind them.
thanks a lot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter edited a comment on pull request #2001: feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#issuecomment-886309280
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2001?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2001](https://codecov.io/gh/apache/apisix-dashboard/pull/2001?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d6e64f8) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/5a581d3f0fa0f74a634af93f14fc779c16454938?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5a581d3) will **increase** coverage by `0.09%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2001?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2001 +/- ##
==========================================
+ Coverage 65.69% 65.79% +0.09%
==========================================
Files 121 121
Lines 3204 3207 +3
Branches 778 778
==========================================
+ Hits 2105 2110 +5
+ Misses 1099 1097 -2
```
| Flag | Coverage Ξ | |
|---|---|---|
| frontend-e2e-test | `65.79% <100.00%> (+0.09%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2001?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2001/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `83.33% <100.00%> (ΓΈ)` | |
| [...b/src/components/Plugin/UI/referer-restriction.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2001/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZWZlcmVyLXJlc3RyaWN0aW9uLnRzeA==) | `72.22% <100.00%> (+5.55%)` | :arrow_up: |
| [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2001/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `72.13% <0.00%> (+3.27%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2001?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2001?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5a581d3...d6e64f8](https://codecov.io/gh/apache/apisix-dashboard/pull/2001?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2001: feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#issuecomment-886164393
π· Deploy Preview for *apisix-dashboard* processing.
π¨ Explore the source changes: c11f0fb2c2c921cf3ff523e178fd021393188172
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/6100214b9774020008d20c3d](https://app.netlify.com/sites/apisix-dashboard/deploys/6100214b9774020008d20c3d?utm_source=github&utm_campaign=bot_dl)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] wmdmomo commented on a change in pull request #2001: feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
wmdmomo commented on a change in pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#discussion_r677542025
##########
File path: web/src/components/Plugin/UI/referer-restriction.tsx
##########
@@ -86,7 +90,7 @@ const RefererRestriction: React.FC<Props> = ({ form }) => {
</Form.Item>
</Col>
<Col style={{ ...removeBtnStyle, marginLeft: -10 }}>
- {fields.length > 1 ? (
+ {fields.length > whiteMinLen ? (
Review comment:
Thanks for your suggestion, I have modified it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] wmdmomo commented on pull request #2001: feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
wmdmomo commented on pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#issuecomment-924541239
> @wmdmomo The code looks good to me. But please pay attention to the errors in CI.
@bzp2010 OK, thanks for your suggestion. The error in CI has been dealt with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #2001: feat(plugin): fix UI referer-restriction
Posted by GitBox <gi...@apache.org>.
netlify[bot] edited a comment on pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#issuecomment-886164393
βοΈ Deploy Preview for *apisix-dashboard* ready!
π¨ Explore the source changes: 631f7b34402fdd5b5676da75bb16d849d47e9d76
π Inspect the deploy log: [https://app.netlify.com/sites/apisix-dashboard/deploys/60fd1c8c19283b0008197cb7](https://app.netlify.com/sites/apisix-dashboard/deploys/60fd1c8c19283b0008197cb7?utm_source=github&utm_campaign=bot_dl)
π Browse the preview: [https://deploy-preview-2001--apisix-dashboard.netlify.app/](https://deploy-preview-2001--apisix-dashboard.netlify.app/?utm_source=github&utm_campaign=bot_dp)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2001: feat(plugin): allowing referer-restriction to dynamically adapt to the BE rules
Posted by GitBox <gi...@apache.org>.
bzp2010 commented on pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#issuecomment-924549739
@wmdmomo Thank you very much for your contribution. XD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2001: feat(plugin): fix UI referer-restriction
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2001:
URL: https://github.com/apache/apisix-dashboard/pull/2001#issuecomment-886309280
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2001?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2001](https://codecov.io/gh/apache/apisix-dashboard/pull/2001?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (631f7b3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/0b5196f0b444dac8acb5cf60635806f024de6a0a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b5196f) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/2001?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #2001 +/- ##
==========================================
+ Coverage 64.01% 64.05% +0.04%
==========================================
Files 122 122
Lines 3154 3158 +4
Branches 753 753
==========================================
+ Hits 2019 2023 +4
Misses 1135 1135
```
| Flag | Coverage Ξ | |
|---|---|---|
| frontend-e2e-test | `64.05% <100.00%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2001?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [web/src/components/Plugin/PluginDetail.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2001/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9QbHVnaW5EZXRhaWwudHN4) | `65.82% <100.00%> (+0.21%)` | :arrow_up: |
| [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2001/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `82.60% <100.00%> (ΓΈ)` | |
| [...b/src/components/Plugin/UI/referer-restriction.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/2001/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9yZWZlcmVyLXJlc3RyaWN0aW9uLnRzeA==) | `72.22% <100.00%> (+5.55%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2001?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2001?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0b5196f...631f7b3](https://codecov.io/gh/apache/apisix-dashboard/pull/2001?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org