You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/25 21:36:56 UTC

[GitHub] [incubator-superset] rusackas opened a new pull request #9023: LESS is more

rusackas opened a new pull request #9023: LESS is more
URL: https://github.com/apache/incubator-superset/pull/9023
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [x] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   This shouldn't change anything in the processed CSS. 
   
   Now that we have LESS everywhere, this PR just goes through and takes advantage of it, tidying up various things readability/grouping
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #9023: LESS is more

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9023: LESS is more
URL: https://github.com/apache/incubator-superset/pull/9023#discussion_r371375748
 
 

 ##########
 File path: superset/assets/src/dashboard/stylesheets/components/column.less
 ##########
 @@ -28,7 +28,6 @@
 
 .dashboard--editing {
   .grid-column:after {
-    border: 1px solid transparent;
 
 Review comment:
   There are a bunch of fairly convoluted styles around the dashed borders in the dashboard editor, which seem like they could use a simplification effort (a future PR, probably). I'll double check that this one wasn't providing some useful 1px offset.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9023: LESS is more

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9023: LESS is more
URL: https://github.com/apache/incubator-superset/pull/9023#discussion_r371337024
 
 

 ##########
 File path: superset/assets/src/SqlLab/main.less
 ##########
 @@ -321,10 +321,9 @@ div.Workspace {
 
 div.tablePopover {
   opacity: 0.7 !important;
-}
-
-div.tablePopover:hover {
-  opacity: 1 !important;
+  &:hover {
 
 Review comment:
   this is a styling thing, but personally i prefer a new line between normal styles and the `&:foo {` line. I think there's a way to lint for that, if so maybe you could add that rule in another PR. if not, maybe we could start standardizing that here if you agree?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] craig-rueda merged pull request #9023: LESS is more

Posted by GitBox <gi...@apache.org>.
craig-rueda merged pull request #9023: LESS is more
URL: https://github.com/apache/incubator-superset/pull/9023
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on issue #9023: LESS is more

Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #9023: LESS is more
URL: https://github.com/apache/incubator-superset/pull/9023#issuecomment-578858540
 
 
   > You could attach a diff on the processed CSS to confirm it's all correct.
   
   I like this idea... will do later today.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9023: LESS is more

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9023: LESS is more
URL: https://github.com/apache/incubator-superset/pull/9023#issuecomment-578445962
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=h1) Report
   > Merging [#9023](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/440665c8477b1313e1fcdc70408af2b8f27e28ba?src=pr&el=desc) will **increase** coverage by `0.28%`.
   > The diff coverage is `80%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9023/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9023      +/-   ##
   ==========================================
   + Coverage   59.15%   59.43%   +0.28%     
   ==========================================
     Files         367      369       +2     
     Lines       11686    11743      +57     
     Branches     2866     2884      +18     
   ==========================================
   + Hits         6913     6980      +67     
   + Misses       4594     4584      -10     
     Partials      179      179
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...assets/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0xpc3RWaWV3L1RhYmxlQ29sbGVjdGlvbi50c3g=) | `92.59% <ø> (ø)` | :arrow_up: |
   | [...perset/assets/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0xpc3RWaWV3L0xpc3RWaWV3LnRzeA==) | `92.2% <100%> (+1.03%)` | :arrow_up: |
   | [...rset/assets/src/components/ConfirmStatusChange.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NvbmZpcm1TdGF0dXNDaGFuZ2UudHN4) | `100% <100%> (ø)` | |
   | [...et/assets/src/components/IndeterminateCheckbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0luZGV0ZXJtaW5hdGVDaGVja2JveC5qc3g=) | `100% <100%> (ø)` | |
   | [superset/assets/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0xpc3RWaWV3L3V0aWxzLnRz) | `98.46% <100%> (+0.31%)` | :arrow_up: |
   | [...uperset/assets/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TcWxFZGl0b3IuanN4) | `51.94% <100%> (ø)` | :arrow_up: |
   | [superset/assets/src/SqlLab/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29uc3RhbnRzLmpz) | `100% <100%> (ø)` | :arrow_up: |
   | [.../assets/src/SqlLab/components/AceEditorWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9BY2VFZGl0b3JXcmFwcGVyLmpzeA==) | `54.21% <33.33%> (ø)` | :arrow_up: |
   | [...t/assets/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aWV3cy9kYXNoYm9hcmRMaXN0L0Rhc2hib2FyZExpc3QudHN4) | `73.39% <61.29%> (+14.44%)` | :arrow_up: |
   | ... and [5 more](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=footer). Last update [440665c...db614f3](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on issue #9023: LESS is more

Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #9023: LESS is more
URL: https://github.com/apache/incubator-superset/pull/9023#issuecomment-580033532
 
 
   @etr2460 I pasted a bunch of diff screenshots above. To get these, I ran the build on master, and on this branch. I then took all the resulting CSS files from each build, removed the annoying hashes from the filenames, ran prettier on them so I could get a reasonable DIFF, and then got the DIFF via github. Hopefully I didn't screw anything up in that process, but I'm feeling pretty good about it overall :D

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on issue #9023: LESS is more

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #9023: LESS is more
URL: https://github.com/apache/incubator-superset/pull/9023#issuecomment-578445962
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=h1) Report
   > Merging [#9023](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/440665c8477b1313e1fcdc70408af2b8f27e28ba?src=pr&el=desc) will **increase** coverage by `0.29%`.
   > The diff coverage is `80%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9023/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9023      +/-   ##
   ==========================================
   + Coverage   59.15%   59.45%   +0.29%     
   ==========================================
     Files         367      369       +2     
     Lines       11686    11747      +61     
     Branches     2866     2888      +22     
   ==========================================
   + Hits         6913     6984      +71     
   + Misses       4594     4584      -10     
     Partials      179      179
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...assets/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0xpc3RWaWV3L1RhYmxlQ29sbGVjdGlvbi50c3g=) | `92.59% <ø> (ø)` | :arrow_up: |
   | [...rset/assets/src/components/ConfirmStatusChange.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NvbmZpcm1TdGF0dXNDaGFuZ2UudHN4) | `100% <100%> (ø)` | |
   | [...perset/assets/src/components/ListView/ListView.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0xpc3RWaWV3L0xpc3RWaWV3LnRzeA==) | `92.2% <100%> (+1.03%)` | :arrow_up: |
   | [superset/assets/src/SqlLab/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29uc3RhbnRzLmpz) | `100% <100%> (ø)` | :arrow_up: |
   | [...et/assets/src/components/IndeterminateCheckbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0luZGV0ZXJtaW5hdGVDaGVja2JveC5qc3g=) | `100% <100%> (ø)` | |
   | [superset/assets/src/components/ListView/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0xpc3RWaWV3L3V0aWxzLnRz) | `98.46% <100%> (+0.31%)` | :arrow_up: |
   | [...uperset/assets/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TcWxFZGl0b3IuanN4) | `51.94% <100%> (ø)` | :arrow_up: |
   | [.../assets/src/SqlLab/components/AceEditorWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9BY2VFZGl0b3JXcmFwcGVyLmpzeA==) | `54.21% <33.33%> (ø)` | :arrow_up: |
   | [...t/assets/src/views/dashboardList/DashboardList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aWV3cy9kYXNoYm9hcmRMaXN0L0Rhc2hib2FyZExpc3QudHN4) | `73.39% <61.29%> (+14.44%)` | :arrow_up: |
   | ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=footer). Last update [440665c...94cdc14](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on issue #9023: LESS is more

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9023: LESS is more
URL: https://github.com/apache/incubator-superset/pull/9023#issuecomment-578445962
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=h1) Report
   > Merging [#9023](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/a85df65f85134901124830d9787c7ac15b6413e9?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9023/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9023      +/-   ##
   ==========================================
   + Coverage   59.15%   59.15%   +<.01%     
   ==========================================
     Files         367      367              
     Lines       11682    11686       +4     
     Branches     2864     2866       +2     
   ==========================================
   + Hits         6910     6913       +3     
   - Misses       4593     4594       +1     
     Partials      179      179
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [.../assets/src/SqlLab/components/AceEditorWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9BY2VFZGl0b3JXcmFwcGVyLmpzeA==) | `54.21% <0%> (-0.11%)` | :arrow_down: |
   | [superset/assets/src/SqlLab/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29uc3RhbnRzLmpz) | `100% <0%> (ø)` | :arrow_up: |
   | [...uperset/assets/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9023/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TcWxFZGl0b3IuanN4) | `51.94% <0%> (+0.31%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=footer). Last update [a85df65...440665c](https://codecov.io/gh/apache/incubator-superset/pull/9023?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9023: LESS is more

Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #9023: LESS is more
URL: https://github.com/apache/incubator-superset/pull/9023#discussion_r371337397
 
 

 ##########
 File path: superset/assets/src/dashboard/stylesheets/components/column.less
 ##########
 @@ -28,7 +28,6 @@
 
 .dashboard--editing {
   .grid-column:after {
-    border: 1px solid transparent;
 
 Review comment:
   lol, what was this?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] craig-rueda commented on issue #9023: LESS is more

Posted by GitBox <gi...@apache.org>.
craig-rueda commented on issue #9023: LESS is more
URL: https://github.com/apache/incubator-superset/pull/9023#issuecomment-578459608
 
 
   LGTM, but prob needs to be tested. This definitely makes things easier to read...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #9023: LESS is more

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #9023: LESS is more
URL: https://github.com/apache/incubator-superset/pull/9023#discussion_r371374514
 
 

 ##########
 File path: superset/assets/src/SqlLab/main.less
 ##########
 @@ -321,10 +321,9 @@ div.Workspace {
 
 div.tablePopover {
   opacity: 0.7 !important;
-}
-
-div.tablePopover:hover {
-  opacity: 1 !important;
+  &:hover {
 
 Review comment:
   I prefer that too, but glad you caught ones I missed. I'll look for a linting rule. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org