You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/31 17:54:00 UTC
[jira] [Commented] (GEODE-3336) Refactor IndexCommandsDUnitTest to
use test rules
[ https://issues.apache.org/jira/browse/GEODE-3336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107687#comment-16107687 ]
ASF GitHub Bot commented on GEODE-3336:
---------------------------------------
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/670
GEODE-3336: Refactor IndexCommandsDUnitTest to use test rules
[View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3336)
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode GEODE-1359
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/670.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #670
----
commit 514018b97c5e5ffab8efbc1e7c119d8bcca64dc1
Author: YehEmily <em...@gmail.com>
Date: 2017-07-26T23:53:27Z
GEODE-1359: Refactor IndexCommandsDUnitTest to use test rules and allow for removal of CliCommandTestBase
----
> Refactor IndexCommandsDUnitTest to use test rules
> -------------------------------------------------
>
> Key: GEODE-3336
> URL: https://issues.apache.org/jira/browse/GEODE-3336
> Project: Geode
> Issue Type: Sub-task
> Components: tests
> Reporter: Emily Yeh
>
> `IndexCommandsDUnitTest` is using `CliCommandTestBase`, which is a deprecated class. It should be refactored to use more current test rules.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)