[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #2582: Build against `arrow-ballista` in CI & remove ballista code from this repo

[GitBox <gi...@apache.org>]

andygrove commented on code in PR #2582:
URL: https://github.com/apache/arrow-datafusion/pull/2582#discussion_r878875387


##########
dev/build-arrow-ballista.sh:
##########
@@ -15,8 +17,18 @@
 # specific language governing permissions and limitations
 # under the License.
 
-# the default configuration location is "/etc/ballista/scheduler.toml"
-# if you include a specifc conf file using "--config-file = my_config_file.toml"
-# then that file will override environment variables, but not command line arguments
-namespace = "my_name_space"
-bind_host = "1.2.3.4"
\ No newline at end of file
+set -e
+
+# delete any previously cloned arrow-ballista repo
+rm -rf arrow-ballista 2>/dev/null
+
+# clone the repo
+# TODO make repo/branch configurable
+git clone https://github.com/apache/arrow-ballista

Review Comment:
   That's a good question and I'm really not sure what the best approach is. Perhaps we wait until we hit this situation and then we can pin to the commit prior to the breaking change.
   
   DataFusion no longer depends on Ballista so I am not sure what kind of change would cause us to deal with this situation but I am sure it is possible somehow. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org