[jira] [Commented] (DRILL-3993) Rebase Drill on Calcite master branch

["Roman (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-3993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149069#comment-16149069 ] 

Roman commented on DRILL-3993:
------------------------------

I am working on updating Drill Calcite version to 1.13. I forked from Calcite "branch-1.13" and added some commits:
- DRILL-1455: Add return type-inference strategy for arithmetic operators when one of the arguments is ANY type. (was not in Calcite)
- Add new method to ViewExpander interface to allow passing SchemaRoot. (was not in Calcite)
- Allow a MAP literal type. (was not in Calcite)
- DRILL-4047: Modify table functions to allow querying a table with options in Drill (was not in Calcite)
- Drill-specific change: Add back AbstractConverter in RelSet.java ... (small changes after a3bc0d8 commit)
- CALCITE-628 related but not fix the problem: Ensure target traits are simple when use Frameworks or RelOptRule.convert() method. (small changes after a3bc0d8 commit)
-  Support select * from schema-less table in execution engine like Drill (small changes after 9bd7d75 commit)

Only after adding these commits to Calcite, a part of  Drill functionality started to work as before. Currently, I am at Drill integration stage. I am fixing Drill unit tests. Progress can be tracked in my branches.

Drill: https://github.com/KulykRoman/drill/commits/CalciteForkRebase_rc1
Calcite: https://github.com/KulykRoman/incubator-calcite/commits/DrillCalcite1.13.0_rc1

Currently, I face ~160 errors in java-exec module unit tests. I have divided them into seven groups:
1) SYSTEM ERROR: ClassCastException
2) Unexpected column errors
3) Runtime Exceptions
4) validation errors
5) RpcExceptions (generalized group: some of them should be fixed by the previous groups)
6) IllegalState errors (generalized group: some of them should be fixed by the previous group)
7) Other errors

> Rebase Drill on Calcite master branch
> -------------------------------------
>
>                 Key: DRILL-3993
>                 URL: https://issues.apache.org/jira/browse/DRILL-3993
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Query Planning & Optimization
>    Affects Versions: 1.2.0
>            Reporter: Sudheesh Katkam
>            Assignee: Roman
>
> Calcite keeps moving, and now we need to catch up to Calcite 1.5, and ensure there are no regressions.
> Also, how do we resolve this 'catching up' issue in the long term?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)