[jira] [Closed] (MSHARED-491) DependencyGraphBuilders shouldn't need reactorProjects for resolving dependencies

["Robert Scholte (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MSHARED-491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Scholte closed MSHARED-491.
----------------------------------
    Resolution: Fixed

Fixed in [b5e9f99802c45b4f0a526c506e11964a61211d89|https://gitbox.apache.org/repos/asf?p=maven-dependency-tree.git;a=commit;h=b5e9f99802c45b4f0a526c506e11964a61211d89]
It turns out that reactorProjects were added as a hack. The code used to resolve artifacts as well, and in case to reactorProjects these could not be resolved if they weren't built yet.
However, dependency-tree is only about poms. With MSHARED-519 being fixed, there should be the no for this anymore, as reactorProject poms are expected to be provided with the WorkspaceReader.

> DependencyGraphBuilders shouldn't need reactorProjects for resolving dependencies
> ---------------------------------------------------------------------------------
>
>                 Key: MSHARED-491
>                 URL: https://issues.apache.org/jira/browse/MSHARED-491
>             Project: Maven Shared Components
>          Issue Type: Improvement
>          Components: maven-dependency-tree
>    Affects Versions: maven-dependency-tree-3.0
>            Reporter: Robert Scholte
>            Assignee: Robert Scholte
>            Priority: Major
>             Fix For: maven-dependency-tree-3.1.0
>
>
> Based on the code it seems that reactor projects are only used in case there are unresolved dependencies, like a fallback.
> Reactor projects should always have a higher priority compared to repository stored artifacts.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)