You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iggy.apache.org by "hubcio (via GitHub)" <gi...@apache.org> on 2026/07/28 12:25:51 UTC
[PR] fix(sdk): forward unknown command codes instead of rejecting them [iggy]
hubcio opened a new pull request, #3766:
URL: https://github.com/apache/iggy/pull/3766
An application built on this SDK cannot reach a command its SDK build
has never heard of. operation_for_code ended None => InvalidCommand,
so a code absent from COMMAND_TABLE failed at encode time, before any
byte left the process, and a server that does implement it never got
the chance to answer. COMMAND_TABLE is a protocol registry, not a
per-server capability list, so the server is the authority on whether
a code exists: an unknown code now ships as non-replicated, carrying
the code in RequestHeader.reserved, and the server answers with a
proper error if it does not know it.
The SDK no longer second-guesses that classification either. It used
to refuse a code the registry knows as replicated, but the server
re-derives the class from the same registry and denies a mismatch on
a path that commits nothing, so the client check duplicated a guard
it does not own. It was unreachable besides, since every replicated
entry resolves through from_command_code first, and it was the sole
construction of an UnknownReplicatedCommand variant nothing in the
tree consumed. operation_for_code is now infallible, the raw-command
documentation no longer explains consensus to callers, and error code
14002 is retired rather than reused.
The client-side namespace derivation goes with it. The server
re-derives the namespace from the request body, and resolves named
identifiers and Balanced or MessagesKey partitioning that the SDK
refused outright, so the client copy was redundant and weaker. Not a
pure deletion: out-of-range stream, topic and partition ids are now
rejected by the server rather than before the request leaves the
process, and a partition op using Balanced or MessagesKey no longer
fails fast client-side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(sdk): forward unknown command codes instead of rejecting them [iggy]
Posted by "spetz (via GitHub)" <gi...@apache.org>.
spetz commented on PR #3766:
URL: https://github.com/apache/iggy/pull/3766#issuecomment-5104362968
Looks good, this should actually close #3758 and simplify a bit #3763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(sdk): forward unknown command codes instead of rejecting them [iggy]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3766:
URL: https://github.com/apache/iggy/pull/3766#issuecomment-5105658202
## [Codecov](https://app.codecov.io/gh/apache/iggy/pull/3766?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 74.13%. Comparing base ([`f88e8a8`](https://app.codecov.io/gh/apache/iggy/commit/f88e8a862260bee326123135327c84da7bc666f7?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`05730ac`](https://app.codecov.io/gh/apache/iggy/commit/05730ace2b5e512effe3c1a31fb31ecb959fd82f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3766 +/- ##
============================================
- Coverage 74.91% 74.13% -0.78%
Complexity 969 969
============================================
Files 1307 1307
Lines 152252 152252
Branches 127684 127684
============================================
- Hits 114052 112865 -1187
- Misses 34682 35951 +1269
+ Partials 3518 3436 -82
```
| [Components](https://app.codecov.io/gh/apache/iggy/pull/3766/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [Rust Core](https://app.codecov.io/gh/apache/iggy/pull/3766/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `75.28% <ø> (ø)` | |
| [Java SDK](https://app.codecov.io/gh/apache/iggy/pull/3766/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `62.71% <ø> (ø)` | |
| [C# SDK](https://app.codecov.io/gh/apache/iggy/pull/3766/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.20% <ø> (ø)` | |
| [Python SDK](https://app.codecov.io/gh/apache/iggy/pull/3766/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `92.27% <ø> (ø)` | |
| [PHP SDK](https://app.codecov.io/gh/apache/iggy/pull/3766/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `84.52% <ø> (ø)` | |
| [Node SDK](https://app.codecov.io/gh/apache/iggy/pull/3766/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `92.24% <ø> (ø)` | |
| [Go SDK](https://app.codecov.io/gh/apache/iggy/pull/3766/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `18.18% <ø> (-24.91%)` | :arrow_down: |
| [Files with missing lines](https://app.codecov.io/gh/apache/iggy/pull/3766?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [core/common/src/error/iggy\_error.rs](https://app.codecov.io/gh/apache/iggy/pull/3766?src=pr&el=tree&filepath=core%2Fcommon%2Fsrc%2Ferror%2Figgy_error.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9jb21tb24vc3JjL2Vycm9yL2lnZ3lfZXJyb3IucnM=) | `100.00% <ø> (ø)` | |
| [core/sdk/src/clients/client.rs](https://app.codecov.io/gh/apache/iggy/pull/3766?src=pr&el=tree&filepath=core%2Fsdk%2Fsrc%2Fclients%2Fclient.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29yZS9zZGsvc3JjL2NsaWVudHMvY2xpZW50LnJz) | `89.22% <ø> (ø)` | |
... and [42 files with indirect coverage changes](https://app.codecov.io/gh/apache/iggy/pull/3766/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(sdk): forward unknown command codes instead of rejecting them [iggy]
Posted by "spetz (via GitHub)" <gi...@apache.org>.
spetz merged PR #3766:
URL: https://github.com/apache/iggy/pull/3766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org