You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/20 15:41:06 UTC
[GitHub] [shardingsphere] terrymanu opened a new pull request #7526: Use ProxyKernelProcessor and JDBCAccessor instead of JdbcExecutorWrapper
terrymanu opened a new pull request #7526:
URL: https://github.com/apache/shardingsphere/pull/7526
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #7526: Use ProxyKernelProcessor and JDBCAccessor instead of JdbcExecutorWrapper
Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #7526:
URL: https://github.com/apache/shardingsphere/pull/7526
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #7526: Use ProxyKernelProcessor and JDBCAccessor instead of JdbcExecutorWrapper
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #7526:
URL: https://github.com/apache/shardingsphere/pull/7526#issuecomment-695805013
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7526?src=pr&el=h1) Report
> Merging [#7526](https://codecov.io/gh/apache/shardingsphere/pull/7526?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e9bf38f6dc87be48c2925d93b97c50f84c3d496f?el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `63.15%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7526/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7526?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7526 +/- ##
============================================
+ Coverage 75.37% 75.38% +0.01%
Complexity 487 487
============================================
Files 1382 1382
Lines 22151 22149 -2
Branches 3945 3945
============================================
+ Hits 16697 16698 +1
+ Misses 4388 4386 -2
+ Partials 1066 1065 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7526?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...nication/jdbc/JDBCDatabaseCommunicationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvSkRCQ0RhdGFiYXNlQ29tbXVuaWNhdGlvbkVuZ2luZS5qYXZh) | `8.19% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...mmunication/jdbc/connection/BackendConnection.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvY29ubmVjdGlvbi9CYWNrZW5kQ29ubmVjdGlvbi5qYXZh) | `87.85% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../execute/engine/jdbc/ProxySQLExecutorCallback.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvZXhlY3V0ZS9lbmdpbmUvamRiYy9Qcm94eVNRTEV4ZWN1dG9yQ2FsbGJhY2suamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...l/MySQLStatementMemoryStrictlyFetchSizeSetter.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvc3RhdGVtZW50L2ZldGNoc2l6ZS9pbXBsL015U1FMU3RhdGVtZW50TWVtb3J5U3RyaWN0bHlGZXRjaFNpemVTZXR0ZXIuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
| [...tgreSQLStatementMemoryStrictlyFetchSizeSetter.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvc3RhdGVtZW50L2ZldGNoc2l6ZS9pbXBsL1Bvc3RncmVTUUxTdGF0ZW1lbnRNZW1vcnlTdHJpY3RseUZldGNoU2l6ZVNldHRlci5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
| [...on/jdbc/execute/engine/jdbc/JDBCExecuteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvZXhlY3V0ZS9lbmdpbmUvamRiYy9KREJDRXhlY3V0ZUVuZ2luZS5qYXZh) | `17.94% <42.85%> (+2.15%)` | `0.00 <0.00> (ø)` | |
| [...ere/proxy/backend/kernel/ProxyKernelProcessor.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9rZXJuZWwvUHJveHlLZXJuZWxQcm9jZXNzb3IuamF2YQ==) | `44.44% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...munication/DatabaseCommunicationEngineFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL0RhdGFiYXNlQ29tbXVuaWNhdGlvbkVuZ2luZUZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ement/accessor/impl/PreparedStatementAccessor.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvc3RhdGVtZW50L2FjY2Vzc29yL2ltcGwvUHJlcGFyZWRTdGF0ZW1lbnRBY2Nlc3Nvci5qYXZh) | `33.33% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...dbc/statement/accessor/impl/StatementAccessor.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvc3RhdGVtZW50L2FjY2Vzc29yL2ltcGwvU3RhdGVtZW50QWNjZXNzb3IuamF2YQ==) | `33.33% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [2 more](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7526?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7526?src=pr&el=footer). Last update [e9bf38f...4eed215](https://codecov.io/gh/apache/shardingsphere/pull/7526?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #7526: Use ProxyKernelProcessor and JDBCAccessor instead of JdbcExecutorWrapper
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7526:
URL: https://github.com/apache/shardingsphere/pull/7526#issuecomment-695804805
## Pull Request Test Coverage Report for [Build 14924](https://coveralls.io/builds/33588898)
* **11** of **28** **(39.29%)** changed or added relevant lines in **8** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage decreased (**-0.003%**) to **35.082%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/kernel/ProxyKernelProcessor.java](https://coveralls.io/builds/33588898/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fkernel%2FProxyKernelProcessor.java#L56) | 1 | 2 | 50.0%
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/execute/engine/jdbc/ProxySQLExecutorCallback.java](https://coveralls.io/builds/33588898/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fengine%2Fjdbc%2FProxySQLExecutorCallback.java#L68) | 0 | 2 | 0.0%
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/JDBCDatabaseCommunicationEngine.java](https://coveralls.io/builds/33588898/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2FJDBCDatabaseCommunicationEngine.java#L67) | 0 | 3 | 0.0%
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/execute/engine/jdbc/JDBCExecuteEngine.java](https://coveralls.io/builds/33588898/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fengine%2Fjdbc%2FJDBCExecuteEngine.java#L84) | 2 | 13 | 15.38%
<!-- | **Total:** | **11** | **28** | **39.29%** | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/33588898/badge)](https://coveralls.io/builds/33588898) |
| :-- | --: |
| Change from base [Build 14919](https://coveralls.io/builds/33588309): | -0.003% |
| Covered Lines: | 36575 |
| Relevant Lines: | 104255 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7526: Use ProxyKernelProcessor and JDBCAccessor instead of JdbcExecutorWrapper
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7526:
URL: https://github.com/apache/shardingsphere/pull/7526#issuecomment-695804805
## Pull Request Test Coverage Report for [Build 14920](https://coveralls.io/builds/33588727)
* **11** of **27** **(40.74%)** changed or added relevant lines in **7** files are covered.
* **40** unchanged lines in **2** files lost coverage.
* Overall coverage increased (+**0.0007%**) to **35.086%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/kernel/ProxyKernelProcessor.java](https://coveralls.io/builds/33588727/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fkernel%2FProxyKernelProcessor.java#L56) | 1 | 2 | 50.0%
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/execute/engine/jdbc/ProxySQLExecutorCallback.java](https://coveralls.io/builds/33588727/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fengine%2Fjdbc%2FProxySQLExecutorCallback.java#L68) | 0 | 2 | 0.0%
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/execute/engine/jdbc/JDBCExecuteEngine.java](https://coveralls.io/builds/33588727/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fengine%2Fjdbc%2FJDBCExecuteEngine.java#L87) | 2 | 15 | 13.33%
<!-- | **Total:** | **11** | **27** | **40.74%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/execute/engine/jdbc/JDBCExecuteEngine.java](https://coveralls.io/builds/33588727/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fengine%2Fjdbc%2FJDBCExecuteEngine.java#L82) | 8 | 17.95% |
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/JDBCDatabaseCommunicationEngine.java](https://coveralls.io/builds/33588727/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2FJDBCDatabaseCommunicationEngine.java#L78) | 32 | 8.2% |
<!-- | **Total:** | **40** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/33588727/badge)](https://coveralls.io/builds/33588727) |
| :-- | --: |
| Change from base [Build 14919](https://coveralls.io/builds/33588309): | 0.0007% |
| Covered Lines: | 36581 |
| Relevant Lines: | 104260 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #7526: Use ProxyKernelProcessor and JDBCAccessor instead of JdbcExecutorWrapper
Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #7526:
URL: https://github.com/apache/shardingsphere/pull/7526
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls edited a comment on pull request #7526: Use ProxyKernelProcessor and JDBCAccessor instead of JdbcExecutorWrapper
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #7526:
URL: https://github.com/apache/shardingsphere/pull/7526#issuecomment-695804805
## Pull Request Test Coverage Report for [Build 14924](https://coveralls.io/builds/33588898)
* **11** of **28** **(39.29%)** changed or added relevant lines in **8** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage decreased (**-0.003%**) to **35.082%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/kernel/ProxyKernelProcessor.java](https://coveralls.io/builds/33588898/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fkernel%2FProxyKernelProcessor.java#L56) | 1 | 2 | 50.0%
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/execute/engine/jdbc/ProxySQLExecutorCallback.java](https://coveralls.io/builds/33588898/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fengine%2Fjdbc%2FProxySQLExecutorCallback.java#L68) | 0 | 2 | 0.0%
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/JDBCDatabaseCommunicationEngine.java](https://coveralls.io/builds/33588898/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2FJDBCDatabaseCommunicationEngine.java#L67) | 0 | 3 | 0.0%
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/execute/engine/jdbc/JDBCExecuteEngine.java](https://coveralls.io/builds/33588898/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fengine%2Fjdbc%2FJDBCExecuteEngine.java#L84) | 2 | 13 | 15.38%
<!-- | **Total:** | **11** | **28** | **39.29%** | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/33588898/badge)](https://coveralls.io/builds/33588898) |
| :-- | --: |
| Change from base [Build 14919](https://coveralls.io/builds/33588309): | -0.003% |
| Covered Lines: | 36575 |
| Relevant Lines: | 104255 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] coveralls commented on pull request #7526: Use ProxyKernelProcessor and JDBCAccessor instead of JdbcExecutorWrapper
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #7526:
URL: https://github.com/apache/shardingsphere/pull/7526#issuecomment-695804805
## Pull Request Test Coverage Report for [Build 14920](https://coveralls.io/builds/33588727)
* **11** of **27** **(40.74%)** changed or added relevant lines in **7** files are covered.
* **40** unchanged lines in **2** files lost coverage.
* Overall coverage increased (+**0.0007%**) to **35.086%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/kernel/ProxyKernelProcessor.java](https://coveralls.io/builds/33588727/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fkernel%2FProxyKernelProcessor.java#L56) | 1 | 2 | 50.0%
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/execute/engine/jdbc/ProxySQLExecutorCallback.java](https://coveralls.io/builds/33588727/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fengine%2Fjdbc%2FProxySQLExecutorCallback.java#L68) | 0 | 2 | 0.0%
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/execute/engine/jdbc/JDBCExecuteEngine.java](https://coveralls.io/builds/33588727/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fengine%2Fjdbc%2FJDBCExecuteEngine.java#L87) | 2 | 15 | 13.33%
<!-- | **Total:** | **11** | **27** | **40.74%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/execute/engine/jdbc/JDBCExecuteEngine.java](https://coveralls.io/builds/33588727/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fexecute%2Fengine%2Fjdbc%2FJDBCExecuteEngine.java#L82) | 8 | 17.95% |
| [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/JDBCDatabaseCommunicationEngine.java](https://coveralls.io/builds/33588727/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2FJDBCDatabaseCommunicationEngine.java#L78) | 32 | 8.2% |
<!-- | **Total:** | **40** | | -->
| Totals | [![Coverage Status](https://coveralls.io/builds/33588727/badge)](https://coveralls.io/builds/33588727) |
| :-- | --: |
| Change from base [Build 14919](https://coveralls.io/builds/33588309): | 0.0007% |
| Covered Lines: | 36581 |
| Relevant Lines: | 104260 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #7526: Use ProxyKernelProcessor and JDBCAccessor instead of JdbcExecutorWrapper
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #7526:
URL: https://github.com/apache/shardingsphere/pull/7526#issuecomment-695805013
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7526?src=pr&el=h1) Report
> Merging [#7526](https://codecov.io/gh/apache/shardingsphere/pull/7526?src=pr&el=desc) into [master](https://codecov.io/gh/apache/shardingsphere/commit/e9bf38f6dc87be48c2925d93b97c50f84c3d496f?el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `63.15%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/7526/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/7526?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7526 +/- ##
============================================
+ Coverage 75.37% 75.38% +0.01%
Complexity 487 487
============================================
Files 1382 1382
Lines 22151 22149 -2
Branches 3945 3945
============================================
+ Hits 16697 16698 +1
+ Misses 4388 4386 -2
+ Partials 1066 1065 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/7526?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...nication/jdbc/JDBCDatabaseCommunicationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvSkRCQ0RhdGFiYXNlQ29tbXVuaWNhdGlvbkVuZ2luZS5qYXZh) | `8.19% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...mmunication/jdbc/connection/BackendConnection.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvY29ubmVjdGlvbi9CYWNrZW5kQ29ubmVjdGlvbi5qYXZh) | `87.85% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [.../execute/engine/jdbc/ProxySQLExecutorCallback.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvZXhlY3V0ZS9lbmdpbmUvamRiYy9Qcm94eVNRTEV4ZWN1dG9yQ2FsbGJhY2suamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...l/MySQLStatementMemoryStrictlyFetchSizeSetter.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvc3RhdGVtZW50L2ZldGNoc2l6ZS9pbXBsL015U1FMU3RhdGVtZW50TWVtb3J5U3RyaWN0bHlGZXRjaFNpemVTZXR0ZXIuamF2YQ==) | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
| [...tgreSQLStatementMemoryStrictlyFetchSizeSetter.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvc3RhdGVtZW50L2ZldGNoc2l6ZS9pbXBsL1Bvc3RncmVTUUxTdGF0ZW1lbnRNZW1vcnlTdHJpY3RseUZldGNoU2l6ZVNldHRlci5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (?)` | |
| [...on/jdbc/execute/engine/jdbc/JDBCExecuteEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvZXhlY3V0ZS9lbmdpbmUvamRiYy9KREJDRXhlY3V0ZUVuZ2luZS5qYXZh) | `17.94% <42.85%> (+2.15%)` | `0.00 <0.00> (ø)` | |
| [...ere/proxy/backend/kernel/ProxyKernelProcessor.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9rZXJuZWwvUHJveHlLZXJuZWxQcm9jZXNzb3IuamF2YQ==) | `44.44% <50.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...munication/DatabaseCommunicationEngineFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL0RhdGFiYXNlQ29tbXVuaWNhdGlvbkVuZ2luZUZhY3RvcnkuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...ement/accessor/impl/PreparedStatementAccessor.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvc3RhdGVtZW50L2FjY2Vzc29yL2ltcGwvUHJlcGFyZWRTdGF0ZW1lbnRBY2Nlc3Nvci5qYXZh) | `33.33% <100.00%> (ø)` | `1.00 <1.00> (?)` | |
| [...dbc/statement/accessor/impl/StatementAccessor.java](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvc3RhdGVtZW50L2FjY2Vzc29yL2ltcGwvU3RhdGVtZW50QWNjZXNzb3IuamF2YQ==) | `33.33% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [2 more](https://codecov.io/gh/apache/shardingsphere/pull/7526/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7526?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/7526?src=pr&el=footer). Last update [e9bf38f...4eed215](https://codecov.io/gh/apache/shardingsphere/pull/7526?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org