You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/06/12 12:28:30 UTC
[GitHub] [camel-kafka-connector] omarsmak opened a new pull request #273: Throw ConnectException due to failed exchanges
omarsmak opened a new pull request #273:
URL: https://github.com/apache/camel-kafka-connector/pull/273
In case we have failed Camel exchanges, we throw `ConnectException` in order to avoid the committing the offsets on failed messages and hence result of loss messages downstream. With this small modification, the task will directly shutdown upon failed exchanges and hence avoid any offsets being committed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] omarsmak commented on pull request #273: Throw ConnectException due to failed exchanges
Posted by GitBox <gi...@apache.org>.
omarsmak commented on pull request #273:
URL: https://github.com/apache/camel-kafka-connector/pull/273#issuecomment-644408895
Indeed @valdar, unit tests here are very important to ensure this always checked as such small modification has a significant semantics impact. I would definitely update this PR with unit tests. Will keep you posted!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] valdar merged pull request #273: Throw ConnectException due to failed exchanges
Posted by GitBox <gi...@apache.org>.
valdar merged pull request #273:
URL: https://github.com/apache/camel-kafka-connector/pull/273
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] omarsmak commented on pull request #273: Throw ConnectException due to failed exchanges
Posted by GitBox <gi...@apache.org>.
omarsmak commented on pull request #273:
URL: https://github.com/apache/camel-kafka-connector/pull/273#issuecomment-644777032
@valdar added unit tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] valdar removed a comment on pull request #273: Throw ConnectException due to failed exchanges
Posted by GitBox <gi...@apache.org>.
valdar removed a comment on pull request #273:
URL: https://github.com/apache/camel-kafka-connector/pull/273#issuecomment-644363357
@omarsmak error handling is a theme in need of more love, so glad you contributed there!
Because it is of great importance as well can I ask you if you could add a test to this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] valdar edited a comment on pull request #273: Throw ConnectException due to failed exchanges
Posted by GitBox <gi...@apache.org>.
valdar edited a comment on pull request #273:
URL: https://github.com/apache/camel-kafka-connector/pull/273#issuecomment-644363357
@omarsmak error handling is a theme in need of more love, so glad you contributed there!
Because it is of great importance as well can I ask you if you could add a test to this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kafka-connector] valdar commented on pull request #273: Throw ConnectException due to failed exchanges
Posted by GitBox <gi...@apache.org>.
valdar commented on pull request #273:
URL: https://github.com/apache/camel-kafka-connector/pull/273#issuecomment-644363357
@omarsmak error handling is a theme in need of more love, so glad you contributed there!
Because it is of great importance as well can I ask you if you could add a test as well to this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org