[GitHub] [arrow] wgtmac commented on a diff in pull request #34580: GH-34432: [Java] NoCompressionCodec throws for unsupported codec type

["wgtmac (via GitHub)" <gi...@apache.org>]

wgtmac commented on code in PR #34580:
URL: https://github.com/apache/arrow/pull/34580#discussion_r1138484592


##########
java/vector/src/main/java/org/apache/arrow/vector/compression/NoCompressionCodec.java:
##########
@@ -61,6 +61,10 @@ public static class Factory implements CompressionCodec.Factory {
 
     @Override
     public CompressionCodec createCodec(CompressionUtil.CodecType codecType) {
+      if (codecType != CompressionUtil.CodecType.NO_COMPRESSION) {
+        throw new IllegalArgumentException(
+            "Unsupported codec type: " + codecType + " for NoCompressionCodec");

Review Comment:
   Sounds good. I have refined the error message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org