You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2015/10/23 18:56:42 UTC
Re: Review Request 39540: Windows: Moved `os::getcwd` to its own file,
`stout/os/getcwd.hpp`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39540/#review103800
-----------------------------------------------------------
Ship it!
Confirmed that `getcwd` logic is unchanged.
3rdparty/libprocess/3rdparty/stout/include/stout/os/getcwd.hpp (line 17)
<https://reviews.apache.org/r/39540/#comment161891>
This isn't used, is it?
- Joseph Wu
On Oct. 21, 2015, 8:36 p.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39540/
> -----------------------------------------------------------
>
> (Updated Oct. 21, 2015, 8:36 p.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Moved `os::getcwd` to its own file, `stout/os/getcwd.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am ba2836a72ceee948cb43364e80ada9f132f33d04
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 7f70c9ea7d57634b5bfd40523ba37561ec92a09a
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/getcwd.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp b6afe0e76366d0bc68d37097ced83a1e14828d84
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 7a8819541506f57f70a9b577dc97a76fc26ebaa8
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 3e6f2aafd0f541f512025dfa683ab4178701f7c4
>
> Diff: https://reviews.apache.org/r/39540/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 39540: Windows: Moved `os::getcwd` to its own file,
`stout/os/getcwd.hpp`.
Posted by Alex Clemmer <cl...@gmail.com>.
> On Oct. 23, 2015, 4:56 p.m., Joseph Wu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/getcwd.hpp, line 17
> > <https://reviews.apache.org/r/39540/diff/1/?file=1103049#file1103049line17>
> >
> > This isn't used, is it?
Ah, yes, I remember thinking that we _should_ make `getcwd` return a `Try`, but forgetting to pull this out later. Oops.
- Alex
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39540/#review103800
-----------------------------------------------------------
On Oct. 22, 2015, 3:36 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39540/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 3:36 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph Wu.
>
>
> Bugs: MESOS-3441
> https://issues.apache.org/jira/browse/MESOS-3441
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Windows: Moved `os::getcwd` to its own file, `stout/os/getcwd.hpp`.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/Makefile.am ba2836a72ceee948cb43364e80ada9f132f33d04
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 7f70c9ea7d57634b5bfd40523ba37561ec92a09a
> 3rdparty/libprocess/3rdparty/stout/include/stout/os/getcwd.hpp PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp b6afe0e76366d0bc68d37097ced83a1e14828d84
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp 7a8819541506f57f70a9b577dc97a76fc26ebaa8
> 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 3e6f2aafd0f541f512025dfa683ab4178701f7c4
>
> Diff: https://reviews.apache.org/r/39540/diff/
>
>
> Testing
> -------
>
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
>
>
> Thanks,
>
> Alex Clemmer
>
>