You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/09/03 23:42:07 UTC
Review Request 38109: Adding a CustomCommands causes Components are
not being displayed in Host view
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38109/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
Bugs: Ambari-12771
https://issues.apache.org/jira/browse/Ambari-12771
Repository: ambari
Description
-------
The intial version of the patch has been submitted by Shantanu Mundkur.
This issue has been reported by Mahesh Kurapati as below:
We are trying to add a CustomCommands to our service in HDP2.3 stack, but once CustomCommands added and restart Ambari in host view we can't see any components. This was working fine in HDP2.2(Ambari-2.0.1).
To reproduce follow below steps:
1. As per the Amabri desgin document https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=38571133, we tried to add a TESTSERVICE service like below which contains customCommands in metainfo.xml:
<?xml version="1.0"?>
<metainfo>
<schemaVersion>2.0</schemaVersion>
<services>
<service>
<name>TESTSERVICE</name>
<displayName>Test Service</displayName>
<version>1.0.0.0</version>
<components>
<component>
<name>TEST_COMPONENT</name>
<displayName>Analytic Metastore</displayName>
<category>MASTER</category>
<cardinality>1</cardinality>
<clientsToUpdateConfigs></clientsToUpdateConfigs>
<commandScript>
<script>scripts/script.py</script>
<scriptType>PYTHON</scriptType>
</commandScript>
<customCommands>
<customCommand>
<name>CustonAction</name>
<commandScript>
<script>scripts/script.py</script>
<scriptType>PYTHON</scriptType>
<timeout>600</timeout>
</commandScript>
</customCommand>
</customCommands>
</component>
</components>
</service>
</services>
</metainfo>
2. restart Ambari server
3. Add service TESTSERVICE to any host
4. goto host view and see all the components not showed.
5. Also Service actions popup menu doesn't show this CustomAction.
Diffs
-----
ambari-web/app/views/main/host/details/host_component_view.js 2665c35
ambari-web/test/views/main/host/details/host_component_view_test.js 2ddc5e4
Diff: https://reviews.apache.org/r/38109/diff/
Testing
-------
Verified that patch works on a live cluster
Verified that all ambari-web unit tests passes:
6709 tests complete (10 seconds)
94 tests pending
Thanks,
Jaimin Jetly
Re: Review Request 38109: Adding a CustomCommands causes Components
are not being displayed in Host view
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38109/#review97684
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Sept. 3, 2015, 9:42 p.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38109/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2015, 9:42 p.m.)
>
>
> Review request for Ambari, Srimanth Gunturi and Yusaku Sako.
>
>
> Bugs: Ambari-12771
> https://issues.apache.org/jira/browse/Ambari-12771
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The intial version of the patch has been submitted by Shantanu Mundkur.
>
> This issue has been reported by Mahesh Kurapati as below:
>
> We are trying to add a CustomCommands to our service in HDP2.3 stack, but once CustomCommands added and restart Ambari in host view we can't see any components. This was working fine in HDP2.2(Ambari-2.0.1).
> To reproduce follow below steps:
> 1. As per the Amabri desgin document https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=38571133, we tried to add a TESTSERVICE service like below which contains customCommands in metainfo.xml:
> <?xml version="1.0"?>
> <metainfo>
> <schemaVersion>2.0</schemaVersion>
> <services>
> <service>
> <name>TESTSERVICE</name>
> <displayName>Test Service</displayName>
> <version>1.0.0.0</version>
> <components>
> <component>
> <name>TEST_COMPONENT</name>
> <displayName>Analytic Metastore</displayName>
> <category>MASTER</category>
> <cardinality>1</cardinality>
> <clientsToUpdateConfigs></clientsToUpdateConfigs>
>
> <commandScript>
> <script>scripts/script.py</script>
> <scriptType>PYTHON</scriptType>
> </commandScript>
> <customCommands>
> <customCommand>
> <name>CustonAction</name>
> <commandScript>
> <script>scripts/script.py</script>
> <scriptType>PYTHON</scriptType>
> <timeout>600</timeout>
> </commandScript>
> </customCommand>
> </customCommands>
> </component>
> </components>
> </service>
> </services>
> </metainfo>
>
> 2. restart Ambari server
> 3. Add service TESTSERVICE to any host
> 4. goto host view and see all the components not showed.
> 5. Also Service actions popup menu doesn't show this CustomAction.
>
>
> Diffs
> -----
>
> ambari-web/app/views/main/host/details/host_component_view.js 2665c35
> ambari-web/test/views/main/host/details/host_component_view_test.js 2ddc5e4
>
> Diff: https://reviews.apache.org/r/38109/diff/
>
>
> Testing
> -------
>
> Verified that patch works on a live cluster
> Verified that all ambari-web unit tests passes:
>
>
> 6709 tests complete (10 seconds)
> 94 tests pending
>
>
> Thanks,
>
> Jaimin Jetly
>
>