You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/04 12:13:46 UTC
[GitHub] [pulsar] lhotari opened a new pull request, #15022: [ML] Fix race condition in updating markDeletePosition
lhotari opened a new pull request, #15022:
URL: https://github.com/apache/pulsar/pull/15022
### Motivation
- there's a race condition in updating markDeletePosition in setAcknowledgedPosition method
### Modifications
- Use `AtomicReferenceFieldUpdater#updateAndGet` to do atomic updates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #15022: [ML] Fix race condition in updating markDeletePosition
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #15022:
URL: https://github.com/apache/pulsar/pull/15022#issuecomment-1088868484
This change wasn't needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari closed pull request #15022: [ML] Fix race condition in updating markDeletePosition
Posted by GitBox <gi...@apache.org>.
lhotari closed pull request #15022: [ML] Fix race condition in updating markDeletePosition
URL: https://github.com/apache/pulsar/pull/15022
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #15022: [ML] Fix race condition in updating markDeletePosition
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #15022:
URL: https://github.com/apache/pulsar/pull/15022#issuecomment-1087531797
It seems that the ReentrantReadWriteLock lock field should already prevent a race from happening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org