You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gastón Kleiman <ga...@mesosphere.io> on 2019/01/18 22:59:24 UTC
Review Request 69791: Made it possible to checkpoint resources without
downgrading them.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69791/
-----------------------------------------------------------
Review request for mesos, Benno Evers and Greg Mann.
Bugs: MESOS-9356
https://issues.apache.org/jira/browse/MESOS-9356
Repository: mesos
Description
-------
For backwards compatibility the agent currently downgrades resources
before checkpointing them.
In order to support providing operation feedback for operation affecting
agent default resources, we're going to start atomically checkpoint
resources and operations in a new file.
Since we're going to checkpoint the resources to a new file that is not
used by old agents, there is no need to downgrade resources before
writing them to that file.
Diffs
-----
src/slave/state.hpp e2180ae37a65a57d1edb29d2ad6cc8232029906e
Diff: https://reviews.apache.org/r/69791/diff/1/
Testing
-------
Current tests still pass.
Thanks,
Gastón Kleiman
Re: Review Request 69791: Made it possible to checkpoint resources
without downgrading them.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69791/#review212282
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Jan. 23, 2019, 6:24 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69791/
> -----------------------------------------------------------
>
> (Updated Jan. 23, 2019, 6:24 p.m.)
>
>
> Review request for mesos, Benno Evers and Greg Mann.
>
>
> Bugs: MESOS-9356
> https://issues.apache.org/jira/browse/MESOS-9356
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For backwards compatibility the agent currently downgrades resources
> before checkpointing them.
>
> In order to support providing operation feedback for operation affecting
> agent default resources, we're going to start atomically checkpointing
> resources and operations in a new file.
>
> Since we're going to checkpoint the resources to a new file that is not
> used by old agents, there is no need to downgrade resources before
> writing them to that file.
>
> Note: this patch doesn't change the format in which resources are
> currently checkpointed.
>
>
> Diffs
> -----
>
> src/slave/state.hpp e2180ae37a65a57d1edb29d2ad6cc8232029906e
>
>
> Diff: https://reviews.apache.org/r/69791/diff/2/
>
>
> Testing
> -------
>
> Current tests still pass.
>
>
> Thanks,
>
> Gastón Kleiman
>
>
Re: Review Request 69791: Made it possible to checkpoint resources
without downgrading them.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69791/
-----------------------------------------------------------
(Updated Jan. 23, 2019, 10:24 a.m.)
Review request for mesos, Benno Evers and Greg Mann.
Changes
-------
Addressed feedback.
Bugs: MESOS-9356
https://issues.apache.org/jira/browse/MESOS-9356
Repository: mesos
Description (updated)
-------
For backwards compatibility the agent currently downgrades resources
before checkpointing them.
In order to support providing operation feedback for operation affecting
agent default resources, we're going to start atomically checkpointing
resources and operations in a new file.
Since we're going to checkpoint the resources to a new file that is not
used by old agents, there is no need to downgrade resources before
writing them to that file.
Note: this patch doesn't change the format in which resources are
currently checkpointed.
Diffs (updated)
-----
src/slave/state.hpp e2180ae37a65a57d1edb29d2ad6cc8232029906e
Diff: https://reviews.apache.org/r/69791/diff/2/
Changes: https://reviews.apache.org/r/69791/diff/1-2/
Testing
-------
Current tests still pass.
Thanks,
Gastón Kleiman
Re: Review Request 69791: Made it possible to checkpoint resources
without downgrading them.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69791/#review212203
-----------------------------------------------------------
In commit message: s/atomically checkpoint/atomically checkpointing/
Also, in the commit message I would add a sentence to the end which makes it explicit that this patch doesn't update any callsites, but simply changes the helper to enable checkpointing without downgrading.
- Greg Mann
On Jan. 18, 2019, 10:59 p.m., Gastón Kleiman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69791/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2019, 10:59 p.m.)
>
>
> Review request for mesos, Benno Evers and Greg Mann.
>
>
> Bugs: MESOS-9356
> https://issues.apache.org/jira/browse/MESOS-9356
>
>
> Repository: mesos
>
>
> Description
> -------
>
> For backwards compatibility the agent currently downgrades resources
> before checkpointing them.
>
> In order to support providing operation feedback for operation affecting
> agent default resources, we're going to start atomically checkpoint
> resources and operations in a new file.
>
> Since we're going to checkpoint the resources to a new file that is not
> used by old agents, there is no need to downgrade resources before
> writing them to that file.
>
>
> Diffs
> -----
>
> src/slave/state.hpp e2180ae37a65a57d1edb29d2ad6cc8232029906e
>
>
> Diff: https://reviews.apache.org/r/69791/diff/1/
>
>
> Testing
> -------
>
> Current tests still pass.
>
>
> Thanks,
>
> Gastón Kleiman
>
>