[GitHub] [incubator-superset] etr2460 commented on a change in pull request #11273: fix: delete the correct dashboard cache key

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #11273:
URL: https://github.com/apache/incubator-superset/pull/11273#discussion_r504990678



##########
File path: superset/models/dashboard.py
##########
@@ -252,8 +252,7 @@ def data(self) -> Dict[str, Any]:
         }
 
     @cache.memoize(
-        # manually maintain cache key version
-        make_name=lambda fname: f"{fname}-v1",
+        make_name=lambda fname: f"{fname}-v0.1",

Review comment:
       why not `v2`?

##########
File path: superset/models/dashboard.py
##########
@@ -294,7 +293,9 @@ def update_thumbnail(self) -> None:
 
     @debounce(0.1)
     def clear_cache(self) -> None:
-        cache.delete_memoized(self.full_data)
+        # pylint: disable=no-member

Review comment:
       why do we need to disable this lint error here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org