You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/05/03 13:57:32 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #23917: feat: Adds an option to Mixed Chart to make Y axes independent of each other
michael-s-molina opened a new pull request, #23917:
URL: https://github.com/apache/superset/pull/23917
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a diff in pull request #23917: feat: Adds a control to set the Secondary Y-axis bounds in Mixed charts
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #23917:
URL: https://github.com/apache/superset/pull/23917#discussion_r1185419205
##########
superset-frontend/plugins/plugin-chart-echarts/src/MixedTimeseries/controlPanel.tsx:
##########
@@ -400,6 +400,23 @@ const config: ControlPanelConfig = {
},
},
],
+ [
+ {
+ name: 'y_axis_bounds_secondary',
+ config: {
+ type: 'BoundsControl',
+ label: t('Secondary y-axis Bounds'),
+ renderTrigger: true,
+ default: yAxisBounds,
+ description: t(
+ `Bounds for the secondary Y-axis. Only works when Independent Y-axes
+ bounds is enabled. When left empty, the bounds are dynamically defined
Review Comment:
```suggestion
`Bounds for the secondary Y-axis. Only works when Independent Y-axis
bounds are enabled. When left empty, the bounds are dynamically defined
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23917: feat: Adds an option to Mixed Chart to make Y axes independent of each other
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23917:
URL: https://github.com/apache/superset/pull/23917#issuecomment-1533210022
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/23917?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23917](https://app.codecov.io/gh/apache/superset/pull/23917?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d2d4821) into [master](https://app.codecov.io/gh/apache/superset/commit/3c381c5361c16732ebf98b74c95c0ad1516a4a39?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3c381c5) will **increase** coverage by `0.02%`.
> The diff coverage is `76.00%`.
> :exclamation: Current head d2d4821 differs from pull request most recent head 8006795. Consider uploading reports for the commit 8006795 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23917 +/- ##
==========================================
+ Coverage 68.08% 68.10% +0.02%
==========================================
Files 1939 1940 +1
Lines 75007 75025 +18
Branches 8154 8159 +5
==========================================
+ Hits 51066 51096 +30
+ Misses 21858 21846 -12
Partials 2083 2083
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `54.45% <57.14%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/23917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...chart-echarts/src/MixedTimeseries/controlPanel.tsx](https://app.codecov.io/gh/apache/superset/pull/23917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvTWl4ZWRUaW1lc2VyaWVzL2NvbnRyb2xQYW5lbC50c3g=) | `56.52% <ø> (ø)` | |
| [...hart-echarts/src/MixedTimeseries/transformProps.ts](https://app.codecov.io/gh/apache/superset/pull/23917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvTWl4ZWRUaW1lc2VyaWVzL3RyYW5zZm9ybVByb3BzLnRz) | `0.00% <0.00%> (ø)` | |
| [.../plugin-chart-echarts/src/MixedTimeseries/types.ts](https://app.codecov.io/gh/apache/superset/pull/23917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvTWl4ZWRUaW1lc2VyaWVzL3R5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [...set-frontend/src/components/Select/AsyncSelect.tsx](https://app.codecov.io/gh/apache/superset/pull/23917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L0FzeW5jU2VsZWN0LnRzeA==) | `88.46% <ø> (ø)` | |
| [superset-frontend/src/components/Select/Select.tsx](https://app.codecov.io/gh/apache/superset/pull/23917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `90.41% <ø> (ø)` | |
| [...nd/src/explore/components/RunQueryButton/index.tsx](https://app.codecov.io/gh/apache/superset/pull/23917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9SdW5RdWVyeUJ1dHRvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/preamble.ts](https://app.codecov.io/gh/apache/superset/pull/23917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
| [superset-frontend/src/setup/setupFormatters.ts](https://app.codecov.io/gh/apache/superset/pull/23917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy50cw==) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/types/bootstrapTypes.ts](https://app.codecov.io/gh/apache/superset/pull/23917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3R5cGVzL2Jvb3RzdHJhcFR5cGVzLnRz) | `100.00% <ø> (ø)` | |
| [superset/cli/native\_filters.py](https://app.codecov.io/gh/apache/superset/pull/23917?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQvY2xpL25hdGl2ZV9maWx0ZXJzLnB5) | `0.00% <ø> (ø)` | |
| ... and [9 more](https://app.codecov.io/gh/apache/superset/pull/23917?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
... and [5 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/23917/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #23917: feat: Adds a control to set the Secondary Y-axis bounds in Mixed charts
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23917:
URL: https://github.com/apache/superset/pull/23917#issuecomment-1535277781
If we're talking about the UI of this thing, I'd love to see all the Query A and Query B controls in tabs :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #23917: feat: Adds a control to set the Secondary Y-axis bounds in Mixed charts
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23917:
URL: https://github.com/apache/superset/pull/23917#issuecomment-1535281009
Not sure if there are any tests that should be cloned as well for good measure, or storybook tweaks, but the logic seems fine to me!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #23917: feat: Adds a control to set the Secondary Y-axis bounds in Mixed charts
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #23917:
URL: https://github.com/apache/superset/pull/23917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org