You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2022/01/25 02:19:22 UTC

[GitHub] [cxf] reta opened a new pull request #895: CXF-8479: fix jaxrs.ee.rs.container.responsecontext getEntityAnnotationsTest

reta opened a new pull request #895:
URL: https://github.com/apache/cxf/pull/895


   Fixing `jaxrs.ee.rs.container.responsecontext getEntityAnnotationsTest`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cxf] reta merged pull request #895: Added test case for response entity with annotations

Posted by GitBox <gi...@apache.org>.
reta merged pull request #895:
URL: https://github.com/apache/cxf/pull/895


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cxf] reta commented on a change in pull request #895: CXF-8479: fix jaxrs.ee.rs.container.responsecontext getEntityAnnotationsTest

Posted by GitBox <gi...@apache.org>.
reta commented on a change in pull request #895:
URL: https://github.com/apache/cxf/pull/895#discussion_r791304120



##########
File path: rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/interceptor/JAXRSOutInterceptor.java
##########
@@ -156,8 +156,8 @@ private void serializeMessage(ServerProviderFactory providerFactory,
         Annotation[] responseAnns = response.getEntityAnnotations();
         if (responseAnns != null) {
             annotations = new Annotation[staticAnns.length + responseAnns.length];
-            System.arraycopy(staticAnns, 0, annotations, 0, staticAnns.length);
-            System.arraycopy(responseAnns, 0, annotations, staticAnns.length, responseAnns.length);
+            System.arraycopy(responseAnns, 0, annotations, 0, responseAnns.length);

Review comment:
       The order of annotations matters for TCK




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [cxf] reta commented on a change in pull request #895: CXF-8479: fix jaxrs.ee.rs.container.responsecontext getEntityAnnotationsTest

Posted by GitBox <gi...@apache.org>.
reta commented on a change in pull request #895:
URL: https://github.com/apache/cxf/pull/895#discussion_r791304120



##########
File path: rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/interceptor/JAXRSOutInterceptor.java
##########
@@ -156,8 +156,8 @@ private void serializeMessage(ServerProviderFactory providerFactory,
         Annotation[] responseAnns = response.getEntityAnnotations();
         if (responseAnns != null) {
             annotations = new Annotation[staticAnns.length + responseAnns.length];
-            System.arraycopy(staticAnns, 0, annotations, 0, staticAnns.length);
-            System.arraycopy(responseAnns, 0, annotations, staticAnns.length, responseAnns.length);
+            System.arraycopy(responseAnns, 0, annotations, 0, responseAnns.length);

Review comment:
       The order of annotations matters for TCK




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cxf.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org