You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "lidavidm (via GitHub)" <gi...@apache.org> on 2025/10/09 02:01:03 UTC
[PR] refactor(rust/ffi): make fields of FFI structs public [arrow-adbc]
lidavidm opened a new pull request, #3553:
URL: https://github.com/apache/arrow-adbc/pull/3553
Closes #3552.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(rust/ffi): make fields of FFI structs public [arrow-adbc]
Posted by "mbrobbel (via GitHub)" <gi...@apache.org>.
mbrobbel commented on PR #3553:
URL: https://github.com/apache/arrow-adbc/pull/3553#issuecomment-3385093841
> private_driver
Makes sense, this should be `pub` or accessible via a `pub` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(rust/ffi): make fields of FFI structs public [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm merged PR #3553:
URL: https://github.com/apache/arrow-adbc/pull/3553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(rust/ffi): make fields of FFI structs public [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #3553:
URL: https://github.com/apache/arrow-adbc/pull/3553#issuecomment-3384736136
In any case, what I'm trying to do is call methods from private_driver (and in the future, possibly patch/replace private_driver) so I expect the only thing you could do is make the fields public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(rust/ffi): make fields of FFI structs public [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #3553:
URL: https://github.com/apache/arrow-adbc/pull/3553#issuecomment-3383780823
CC @eitsupi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor(rust/ffi): make fields of FFI structs public [arrow-adbc]
Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on PR #3553:
URL: https://github.com/apache/arrow-adbc/pull/3553#issuecomment-3384731923
This is already the FFI/unsafe layer, though. I don't think there's value in investing into a lot of abstraction when it's not clear what abstractions (if any) are valuable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org