You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/06 04:00:19 UTC
[GitHub] [incubator-superset] rusackas commented on a change in pull request #11578: fix: Issues with filters and metrics popovers
rusackas commented on a change in pull request #11578:
URL: https://github.com/apache/incubator-superset/pull/11578#discussion_r518510325
##########
File path: superset-frontend/src/explore/components/AdhocMetricEditPopover.jsx
##########
@@ -50,7 +50,11 @@ const defaultProps = {
columns: [],
};
-const startingWidth = 300;
+const ResizeIcon = styled.i`
Review comment:
I see this is happening a couple times in this PR, but I can't think of an easy way to DRY this up that would be worth doing if we come through and start replacing all the font-awesome icons in another pass anyway. Only mentioning it in case you have an idea of how to simply consolidate the two `ResizeIcon` instances... but it's probably not worth worrying about. So now I'm just rambling...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org