[GitHub] [arrow-adbc] paleolimbot opened a new issue, #1066: r: Add quoting functions to R bindings

["paleolimbot (via GitHub)" <gi...@apache.org>]

paleolimbot opened a new issue, #1066:
URL: https://github.com/apache/arrow-adbc/issues/1066

   In DBI we have `DBI::dbQuoteIdentifier()` and `DBI::dbQuoteLiteral()`. When R users are trying to write generic database code they often need these for safety (e.g., `glue::glue_sql()` uses them to prevent against SQL injection attacks). We may want to consider dealing with these at a generic level (i.e., piped through one of the C ADBC entrypoints); however in the meantime we can support this in the R bindings. Functionally, we need an S3 generic:
   
   ```r
   adbc_quote_identifier <- function(connection, x, ...) {
     UseMethod("adbc_quote_identifier")
   }
   
   adbc_quote_literal <- function(connection, x, ...) {
     UseMethod("adbc_quote_identifier")
   }
   ```
   
   ...and an implementation in driver packages that support this operation via a C entry point (e.g., SQLite, libpq).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-adbc] lidavidm closed issue #1066: r: Add quoting functions to R bindings

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm closed issue #1066: r: Add quoting functions to R bindings
URL: https://github.com/apache/arrow-adbc/issues/1066


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-adbc] lidavidm commented on issue #1066: r: Add quoting functions to R bindings

["lidavidm (via GitHub)" <gi...@apache.org>]

lidavidm commented on issue #1066:
URL: https://github.com/apache/arrow-adbc/issues/1066#issuecomment-1719798428

   And for the record I think we can eventually move this down into the drivers themselves if it proves more generally useful (e.g. `AdbcDatabaseGetOption("adbc.quote.identifier.your identifier here")`, which is maybe a bit hacky, but would work without having to go add a bunch of new entrypoints)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org