You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/11 14:08:14 UTC
[GitHub] [flink] XComp opened a new pull request #14609: [FLINK-20916][runtime] Remove obsolete testcase
XComp opened a new pull request #14609:
URL: https://github.com/apache/flink/pull/14609
## What is the purpose of the change
The test itself does not test the functionality it complains to test. The
JobManagerCustomLogHandler does not decode the URL encoding at all. The URL
parsing and decoding happens already earlier in the process (see [RouterHandler
which utilizes QueryStringDecoder](https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-runtime/src/main/java/org/apache/flink/runtime/rest/handler/router/RouterHandler.java#L86) and parses the PathParameter objects). It
does not need to be tested individually in this test class. Hence, this
testcase is obsolete and, therefore, can be deleted.
## Brief change log
Test was deleted.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14609: [FLINK-20916][runtime] Remove obsolete testcase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14609:
URL: https://github.com/apache/flink/pull/14609#issuecomment-757985293
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17beba85aeaae271e347e65b6df0dc6a8311057a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11884",
"triggerID" : "17beba85aeaae271e347e65b6df0dc6a8311057a",
"triggerType" : "PUSH"
}, {
"hash" : "c2d5b34626c90f481c9a7ee37d036c53119f98e3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c2d5b34626c90f481c9a7ee37d036c53119f98e3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17beba85aeaae271e347e65b6df0dc6a8311057a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11884)
* c2d5b34626c90f481c9a7ee37d036c53119f98e3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14609: [FLINK-20916][runtime] Remove obsolete testcase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14609:
URL: https://github.com/apache/flink/pull/14609#issuecomment-757985293
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17beba85aeaae271e347e65b6df0dc6a8311057a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11884",
"triggerID" : "17beba85aeaae271e347e65b6df0dc6a8311057a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17beba85aeaae271e347e65b6df0dc6a8311057a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11884)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14609: [FLINK-20916][runtime] Remove obsolete testcase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14609:
URL: https://github.com/apache/flink/pull/14609#issuecomment-757975251
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c2d5b34626c90f481c9a7ee37d036c53119f98e3 (Fri May 28 07:06:54 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] XComp commented on a change in pull request #14609: [FLINK-20916][runtime] Remove obsolete testcase
Posted by GitBox <gi...@apache.org>.
XComp commented on a change in pull request #14609:
URL: https://github.com/apache/flink/pull/14609#discussion_r556446214
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/cluster/JobManagerCustomLogHandlerTest.java
##########
@@ -92,6 +92,7 @@ private static void createFile(File file, String content) throws IOException {
private static HandlerRequest<EmptyRequestBody, FileMessageParameters> createHandlerRequest(
String path) throws HandlerRequestException {
+ System.out.println(path);
Review comment:
uuuh, good catch. And thanks - I removed the line that was accidentally push. 😇
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14609: [FLINK-20916][runtime] Remove obsolete testcase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14609:
URL: https://github.com/apache/flink/pull/14609#issuecomment-757985293
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17beba85aeaae271e347e65b6df0dc6a8311057a",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11884",
"triggerID" : "17beba85aeaae271e347e65b6df0dc6a8311057a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17beba85aeaae271e347e65b6df0dc6a8311057a Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11884)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14609: [FLINK-20916][runtime] Remove obsolete testcase
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14609:
URL: https://github.com/apache/flink/pull/14609#issuecomment-757985293
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17beba85aeaae271e347e65b6df0dc6a8311057a",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "17beba85aeaae271e347e65b6df0dc6a8311057a",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17beba85aeaae271e347e65b6df0dc6a8311057a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger merged pull request #14609: [FLINK-20916][runtime] Remove obsolete testcase
Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #14609:
URL: https://github.com/apache/flink/pull/14609
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14609: [FLINK-20916][runtime] Remove obsolete testcase
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14609:
URL: https://github.com/apache/flink/pull/14609#issuecomment-757975251
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 17beba85aeaae271e347e65b6df0dc6a8311057a (Mon Jan 11 14:10:08 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14609: [FLINK-20916][runtime] Remove obsolete testcase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14609:
URL: https://github.com/apache/flink/pull/14609#issuecomment-757985293
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "17beba85aeaae271e347e65b6df0dc6a8311057a",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11884",
"triggerID" : "17beba85aeaae271e347e65b6df0dc6a8311057a",
"triggerType" : "PUSH"
}, {
"hash" : "c2d5b34626c90f481c9a7ee37d036c53119f98e3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11988",
"triggerID" : "c2d5b34626c90f481c9a7ee37d036c53119f98e3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 17beba85aeaae271e347e65b6df0dc6a8311057a Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11884)
* c2d5b34626c90f481c9a7ee37d036c53119f98e3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11988)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #14609: [FLINK-20916][runtime] Remove obsolete testcase
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #14609:
URL: https://github.com/apache/flink/pull/14609#discussion_r555092053
##########
File path: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/cluster/JobManagerCustomLogHandlerTest.java
##########
@@ -92,6 +92,7 @@ private static void createFile(File file, String content) throws IOException {
private static HandlerRequest<EmptyRequestBody, FileMessageParameters> createHandlerRequest(
String path) throws HandlerRequestException {
+ System.out.println(path);
Review comment:
I guess this is a leftover
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org