You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/06 03:12:44 UTC

[GitHub] [arrow-rs] liukun4515 commented on a diff in pull request #2650: Overflow-checking variant of arithmetic scalar kernels

liukun4515 commented on code in PR #2650:
URL: https://github.com/apache/arrow-rs/pull/2650#discussion_r963215619


##########
arrow/src/compute/kernels/arity.rs:
##########
@@ -83,6 +84,41 @@ where
     PrimitiveArray::<O>::from(data)
 }
 
+/// A overflow-checking variant of `unary`.
+pub(crate) fn unary_checked<I, F, O>(

Review Comment:
   I think this should be `try_unary` and it's common method for `primitive array`
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org