You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/22 23:57:47 UTC
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10401: fix: remove FAB rendered menu in favor of react based one
codecov-commenter commented on pull request #10401:
URL: https://github.com/apache/incubator-superset/pull/10401#issuecomment-662755392
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10401?src=pr&el=h1) Report
> Merging [#10401](https://codecov.io/gh/apache/incubator-superset/pull/10401?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ca71d4d6ee7fabef527ba7a79b0071a2d4a0f522&el=desc) will **increase** coverage by `0.98%`.
> The diff coverage is `62.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10401?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10401 +/- ##
==========================================
+ Coverage 70.51% 71.50% +0.98%
==========================================
Files 604 409 -195
Lines 32420 13409 -19011
Branches 3298 3300 +2
==========================================
- Hits 22862 9588 -13274
+ Misses 9454 3715 -5739
- Partials 104 106 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.93% <100.00%> (+0.22%)` | :arrow_up: |
| #javascript | `59.29% <0.00%> (-0.04%)` | :arrow_down: |
| #python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10401?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/welcome/menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10401/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3dlbGNvbWUvbWVudS50c3g=) | `62.50% <62.50%> (ø)` | |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/10401/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10401/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10401/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `62.60% <0.00%> (-2.57%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10401/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `39.41% <0.00%> (-1.66%)` | :arrow_down: |
| [superset/utils/dict\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/10401/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGljdF9pbXBvcnRfZXhwb3J0LnB5) | | |
| [superset/charts/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/10401/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2Rhby5weQ==) | | |
| [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/10401/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | | |
| [superset/queries/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10401/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9maWx0ZXJzLnB5) | | |
| [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/10401/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=) | | |
| ... and [193 more](https://codecov.io/gh/apache/incubator-superset/pull/10401/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10401?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10401?src=pr&el=footer). Last update [ca71d4d...fa83c83](https://codecov.io/gh/apache/incubator-superset/pull/10401?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org