You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2017/10/24 17:55:44 UTC
[Impala-ASF-CR] IMPALA-6076: Parquet BIT PACKED deprecation warning
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8370
Change subject: IMPALA-6076: Parquet BIT_PACKED deprecation warning
......................................................................
IMPALA-6076: Parquet BIT_PACKED deprecation warning
Every 100th time that we open a Parquet column with the
deprecated BIT_PACKED encoding, an error is logged. We do this
per-column instead of per-file because Impala historically
listed the BIT_PACKED encoding in file metadata even when it
wasn't used for any columns - see IMPALA-5636.
Testing:
Manually tested by running a query repeatedly against a
BIT_PACKED sample file (which I created for my IMPALA-4177
patch). Ran "tail -f logs/cluster/impalad.WARNING" and checked
that the warning was logged periodically.
Change-Id: I02dd4009089a264b28376492b1b40361d767d5d9
---
M be/src/exec/parquet-column-readers.cc
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/70/8370/1
--
To view, visit http://gerrit.cloudera.org:8080/8370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02dd4009089a264b28376492b1b40361d767d5d9
Gerrit-Change-Number: 8370
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6076: Parquet BIT PACKED deprecation warning
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8370 )
Change subject: IMPALA-6076: Parquet BIT_PACKED deprecation warning
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02dd4009089a264b28376492b1b40361d767d5d9
Gerrit-Change-Number: 8370
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Oct 2017 18:07:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6076: Parquet BIT PACKED deprecation warning
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8370 )
Change subject: IMPALA-6076: Parquet BIT_PACKED deprecation warning
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02dd4009089a264b28376492b1b40361d767d5d9
Gerrit-Change-Number: 8370
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Oct 2017 22:11:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6076: Parquet BIT PACKED deprecation warning
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8370 )
Change subject: IMPALA-6076: Parquet BIT_PACKED deprecation warning
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1375/
--
To view, visit http://gerrit.cloudera.org:8080/8370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I02dd4009089a264b28376492b1b40361d767d5d9
Gerrit-Change-Number: 8370
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Comment-Date: Tue, 24 Oct 2017 18:11:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6076: Parquet BIT PACKED deprecation warning
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8370 )
Change subject: IMPALA-6076: Parquet BIT_PACKED deprecation warning
......................................................................
IMPALA-6076: Parquet BIT_PACKED deprecation warning
Every 100th time that we open a Parquet column with the
deprecated BIT_PACKED encoding, an error is logged. We do this
per-column instead of per-file because Impala historically
listed the BIT_PACKED encoding in file metadata even when it
wasn't used for any columns - see IMPALA-5636.
Testing:
Manually tested by running a query repeatedly against a
BIT_PACKED sample file (which I created for my IMPALA-4177
patch). Ran "tail -f logs/cluster/impalad.WARNING" and checked
that the warning was logged periodically.
Change-Id: I02dd4009089a264b28376492b1b40361d767d5d9
Reviewed-on: http://gerrit.cloudera.org:8080/8370
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/exec/parquet-column-readers.cc
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Lars Volker: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8370
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I02dd4009089a264b28376492b1b40361d767d5d9
Gerrit-Change-Number: 8370
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>