You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "SinBex (via GitHub)" <gi...@apache.org> on 2023/03/31 03:20:03 UTC
[GitHub] [flink] SinBex opened a new pull request, #22311: [FLINK-31652][k8s] Handle the deleted event in case pod is deleted during the pending phase
SinBex opened a new pull request, #22311:
URL: https://github.com/apache/flink/pull/22311
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Currently, in kubernetes deployment, if the taskmanager pod is deleted in 'Pending' phase, the flink job will get stuck and keep waiting for the pod scheduled. The cause reason is that the pod status will not be updated in time, so the KubernetesResourceManagerDriver won't detect the pod is terminated, but should handle the deleted event.
## Brief change log
- The method KubernetesResourceManagerDriver#handlePodEventsInMainThread handle the deleted event
## Verifying this change
- Add UT in `KubernetesResourceManagerDriverTest#testOnPodDeletedWithDeletedEvent`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes)
- The S3 file system connector: ( no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on a diff in pull request #22311: [FLINK-31652][k8s] Handle the deleted event in case pod is deleted during the pending phase
Posted by "xintongsong (via GitHub)" <gi...@apache.org>.
xintongsong commented on code in PR #22311:
URL: https://github.com/apache/flink/pull/22311#discussion_r1155446163
##########
flink-kubernetes/src/test/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriverTest.java:
##########
@@ -184,6 +184,18 @@ void testOnPodDeleted() throws Exception {
};
}
+ @Test
+ void testOnPodDeletedWithDeletedEvent() throws Exception {
Review Comment:
```suggestion
void testOnPodDeletedBeforeScheduled() throws Exception {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SinBex commented on pull request #22311: [FLINK-31652][k8s] Handle the deleted event in case pod is deleted during the pending phase
Posted by "SinBex (via GitHub)" <gi...@apache.org>.
SinBex commented on PR #22311:
URL: https://github.com/apache/flink/pull/22311#issuecomment-1491322025
Thank you so much for your review @huwh , I have updated the code, PTAL~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #22311: [FLINK-31652][k8s] Handle the deleted event in case pod is deleted during the pending phase
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22311:
URL: https://github.com/apache/flink/pull/22311#issuecomment-1491237551
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "2cba48fe3f868381707aa949f6f2132f6981ebf9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2cba48fe3f868381707aa949f6f2132f6981ebf9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2cba48fe3f868381707aa949f6f2132f6981ebf9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong closed pull request #22311: [FLINK-31652][k8s] Handle the deleted event in case pod is deleted during the pending phase
Posted by "xintongsong (via GitHub)" <gi...@apache.org>.
xintongsong closed pull request #22311: [FLINK-31652][k8s] Handle the deleted event in case pod is deleted during the pending phase
URL: https://github.com/apache/flink/pull/22311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SinBex commented on a diff in pull request #22311: [FLINK-31652][k8s] Handle the deleted event in case pod is deleted during the pending phase
Posted by "SinBex (via GitHub)" <gi...@apache.org>.
SinBex commented on code in PR #22311:
URL: https://github.com/apache/flink/pull/22311#discussion_r1154031487
##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java:
##########
@@ -65,6 +67,11 @@
import java.util.concurrent.CancellationException;
import java.util.concurrent.CompletableFuture;
+import static io.fabric8.kubernetes.client.Watcher.Action.ADDED;
Review Comment:
Thanks for your suggestion. It is indeed better not to introduce an external class, I will use an internal enum to replace it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] SinBex commented on pull request #22311: [FLINK-31652][k8s] Handle the deleted event in case pod is deleted during the pending phase
Posted by "SinBex (via GitHub)" <gi...@apache.org>.
SinBex commented on PR #22311:
URL: https://github.com/apache/flink/pull/22311#issuecomment-1491245093
@xintongsong Could you please help to review this PR in your free time? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] huwh commented on a diff in pull request #22311: [FLINK-31652][k8s] Handle the deleted event in case pod is deleted during the pending phase
Posted by "huwh (via GitHub)" <gi...@apache.org>.
huwh commented on code in PR #22311:
URL: https://github.com/apache/flink/pull/22311#discussion_r1153988699
##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java:
##########
@@ -65,6 +67,11 @@
import java.util.concurrent.CancellationException;
import java.util.concurrent.CompletableFuture;
+import static io.fabric8.kubernetes.client.Watcher.Action.ADDED;
Review Comment:
It's better not use fabric classes in KubernetesResourceManagerDriver since these are Flink internal logic.
##########
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesResourceManagerDriver.java:
##########
@@ -340,12 +347,12 @@ private KubernetesTaskManagerParameters createKubernetesTaskManagerParameters(
blockedNodes);
}
- private void handlePodEventsInMainThread(List<KubernetesPod> pods) {
+ private void handlePodEventsInMainThread(List<KubernetesPod> pods, Action action) {
getMainThreadExecutor()
.execute(
() -> {
for (KubernetesPod pod : pods) {
- if (pod.isTerminated()) {
+ if (action == DELETED || pod.isTerminated()) {
Review Comment:
We need some annotations to explain why we need this logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org