You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/02/18 04:53:33 UTC
[GitHub] [cordova-ios] dpogue opened a new pull request #790: CB-13143:
Integrate and replace SplashScreens with Launch Storyboard
dpogue opened a new pull request #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard
URL: https://github.com/apache/cordova-ios/pull/790
### Platforms affected
iOS
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
1. Apple is deprecating Launch Images and will require Launch Storyboards for all apps as of April 2020 (Closes #770).
2. As per the decisions resulting from the plugin audit, [CB-13143](https://issues.apache.org/jira/browse/CB-13143) intends to integrate the SplashScreen plugin API into each native platform and deprecate the plugin.
### Description
<!-- Describe your changes in detail -->
* Remove the default Launch Images
* Remove support for Launch Images from the `prepare` step
* Integrate the required functionality for showing/hiding a screenshot of the Launch Storyboard to `CDVViewController`
* Add a built-in plugin with the same API as the SplashScreen plugin
### Testing
<!-- Please describe in detail how you tested your changes. -->
* Manually created a test app and verified the launch storyboard behaviour.
* Manually confirmed the SplashScreen API works as intended from the JS side.
### Checklist
- [ ] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #790: CB-13143:
Integrate and replace SplashScreens with Launch Storyboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-588039061
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=h1) Report
> Merging [#790](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/4ac155251e78b59ea74c91f29ab0353721dba475?src=pr&el=desc) will **increase** coverage by `0.43%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #790 +/- ##
=========================================
+ Coverage 74.36% 74.8% +0.43%
=========================================
Files 13 13
Lines 1845 1766 -79
=========================================
- Hits 1372 1321 -51
+ Misses 473 445 -28
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/790/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `86.63% <100%> (+3.84%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=footer). Last update [4ac1552...f27f4cb](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #790: CB-13143:
Integrate and replace SplashScreens with Launch Storyboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-588039061
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=h1) Report
> Merging [#790](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/29224370fff52dd3ee210bdf49571f338c0770c6?src=pr&el=desc) will **increase** coverage by `0.43%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #790 +/- ##
==========================================
+ Coverage 74.2% 74.63% +0.43%
==========================================
Files 13 13
Lines 1849 1770 -79
==========================================
- Hits 1372 1321 -51
+ Misses 477 449 -28
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/790/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `85.71% <100%> (+3.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=footer). Last update [2922437...a1d5c03](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] erisu edited a comment on issue #790: CB-13143:
Integrate and replace SplashScreens with Launch Storyboard
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on issue #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-593810514
During testing, this PR will also no longer provide or display the default Cordova splashscreen as designed. Same behaviour as Android platform to not show a default splashscreen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] erisu commented on issue #790: CB-13143: Integrate
and replace SplashScreens with Launch Storyboard
Posted by GitBox <gi...@apache.org>.
erisu commented on issue #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-593810514
During testing, this PR will also no longer provide or display the default Cordova splashscreen as designed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #790: CB-13143:
Integrate and replace SplashScreens with Launch Storyboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-588039061
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=h1) Report
> Merging [#790](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/4ac155251e78b59ea74c91f29ab0353721dba475?src=pr&el=desc) will **increase** coverage by `0.43%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #790 +/- ##
=========================================
+ Coverage 74.36% 74.8% +0.43%
=========================================
Files 13 13
Lines 1845 1766 -79
=========================================
- Hits 1372 1321 -51
+ Misses 473 445 -28
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/790/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `86.63% <100%> (+3.84%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=footer). Last update [4ac1552...e1fbb8a](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] erisu commented on issue #790: CB-13143: Integrate
and replace SplashScreens with Launch Storyboard
Posted by GitBox <gi...@apache.org>.
erisu commented on issue #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-599178509
Documentation would need to go into `cordova-doc`.
Only the plugin documentation were written within its own repos and then the `cordova-doc` repo would grab it. Platform docs were manually managed directly in `cordova-doc`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #790: CB-13143:
Integrate and replace SplashScreens with Launch Storyboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-588039061
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=h1) Report
> Merging [#790](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/4ac155251e78b59ea74c91f29ab0353721dba475?src=pr&el=desc) will **increase** coverage by `0.43%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #790 +/- ##
=========================================
+ Coverage 74.36% 74.8% +0.43%
=========================================
Files 13 13
Lines 1845 1766 -79
=========================================
- Hits 1372 1321 -51
+ Misses 473 445 -28
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/790/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `86.63% <100%> (+3.84%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=footer). Last update [4ac1552...f27f4cb](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] erisu edited a comment on issue #790: CB-13143:
Integrate and replace SplashScreens with Launch Storyboard
Posted by GitBox <gi...@apache.org>.
erisu edited a comment on issue #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-587342386
@dpogue I pushed an update to remove the unit tests that I forgot to remove in the commit that you cherry picked. `refactor (prepare): delete legacy splash screen launch images`. The Jasmine unit tests should be OK now.
Locally I saw another error but from the Objective-C tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue commented on issue #790: CB-13143: Integrate
and replace SplashScreens with Launch Storyboard
Posted by GitBox <gi...@apache.org>.
dpogue commented on issue #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-588035182
@erisu FYI I rebased and squashed your Jasmine test fix commit into the one where the prepare code was removed.
This should hopefully pass all the Obj-C tests too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io commented on issue #790: CB-13143:
Integrate and replace SplashScreens with Launch Storyboard
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-588039061
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=h1) Report
> Merging [#790](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/4ac155251e78b59ea74c91f29ab0353721dba475?src=pr&el=desc) will **increase** coverage by `0.43%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #790 +/- ##
=========================================
+ Coverage 74.36% 74.8% +0.43%
=========================================
Files 13 13
Lines 1845 1766 -79
=========================================
- Hits 1372 1321 -51
+ Misses 473 445 -28
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/790/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `86.63% <100%> (+3.84%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=footer). Last update [4ac1552...e1fbb8a](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #790: CB-13143:
Integrate and replace SplashScreens with Launch Storyboard
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-588039061
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=h1) Report
> Merging [#790](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/4ac155251e78b59ea74c91f29ab0353721dba475?src=pr&el=desc) will **increase** coverage by `0.43%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #790 +/- ##
=========================================
+ Coverage 74.36% 74.8% +0.43%
=========================================
Files 13 13
Lines 1845 1766 -79
=========================================
- Hits 1372 1321 -51
+ Misses 473 445 -28
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/790/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `86.63% <100%> (+3.84%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=footer). Last update [4ac1552...f27f4cb](https://codecov.io/gh/apache/cordova-ios/pull/790?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] erisu commented on issue #790: CB-13143: Integrate
and replace SplashScreens with Launch Storyboard
Posted by GitBox <gi...@apache.org>.
erisu commented on issue #790: CB-13143: Integrate and replace SplashScreens with Launch Storyboard
URL: https://github.com/apache/cordova-ios/pull/790#issuecomment-587342386
@dpogue I pushed an update to remove the unit tests that I forgot to remove in the commit that you cherry picked. `refactor (prepare): delete legacy splash screen launch images`. The Jasmine unit tests should be OK now.
Locally I saw another error but from the building test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org