You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Andris Mednis (JIRA)" <ji...@apache.org> on 2012/10/12 11:45:03 UTC
[jira] [Commented] (THRIFT-1414) bufferoverflow in c_glib buffered
transport/socket client
[ https://issues.apache.org/jira/browse/THRIFT-1414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474920#comment-13474920 ]
Andris Mednis commented on THRIFT-1414:
---------------------------------------
Can you tell where is this fix ? Cannot find it in trunk yet.
> bufferoverflow in c_glib buffered transport/socket client
> ---------------------------------------------------------
>
> Key: THRIFT-1414
> URL: https://issues.apache.org/jira/browse/THRIFT-1414
> Project: Thrift
> Issue Type: Bug
> Components: C glib - Library
> Affects Versions: 0.7
> Environment: Server running on Windows 7 SP1 64bit based on csharp.
> Client running on Ubuntu 11.04 Server 64 bit (fresh install) based on c_glib.
> svn rev: 1190015M
> Reporter: Christian Zimnick
> Priority: Critical
> Attachments: THRIFT-1414.patch
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> Quote of comment in source:
> -----------------------------------------------
> if the buffer is still smaller than what we
> want to read, then just read it directly.
> -----------------------------------------------
> But the code reading into the tempdata with size of the buffer and reading all data into this.
> file: lib/c_glib/transport/thrift_buffered_transport.c line 74/98
> Also if the buffer is still bigger that what we want to read, then reading the buffer size.
> But recv blocks than and waiting of data if there nothing to read after the receiving data len.
> file: lib/c_glib/transport/thrift_buffered_transport.c line 118
> i attached a patch that fix this problems but i dont know if all of this is correct.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira