You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/15 05:04:54 UTC

[GitHub] [beam] saavan-google-intern commented on pull request #12009: [BEAM-10258] Support type hint annotations on PTransform's expand()

saavan-google-intern commented on pull request #12009:
URL: https://github.com/apache/beam/pull/12009#issuecomment-643904266


   R: @udim 
   CC: @robertwb 
   
   This PR is not ready for merge, but I'm making it available so we can track and discuss its progress.
   
   What do you think of the current implementation? It works on some trivial pipelines that I've run on my machine but I want to confirm the solution's design before I debug deeper and write real tests.
   
   Also what is the expected behavior for runtime type checking with annotations? For example, if an input PCollection to a PTransform is annotated with the type hint _PCollection[str]_, should the runtime type checking system confirm that each element in the PCollection is indeed a string? Is this how the current runtime type checking system works with decorators and inline type hints?
   
   Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org