[GitHub] flink pull request #5327: [FLINK-8428] [table] Implement stream-stream non-w...

[twalthr <gi...@git.apache.org>]

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5327#discussion_r182431730
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/join/NonWindowLeftRightJoin.scala ---
    @@ -0,0 +1,96 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.flink.table.runtime.join
    +
    +import org.apache.flink.api.common.state._
    +import org.apache.flink.api.common.typeinfo.TypeInformation
    +import org.apache.flink.api.java.tuple.{Tuple2 => JTuple2}
    +import org.apache.flink.configuration.Configuration
    +import org.apache.flink.streaming.api.functions.co.CoProcessFunction
    +import org.apache.flink.table.api.StreamQueryConfig
    +import org.apache.flink.table.runtime.types.CRow
    +import org.apache.flink.types.Row
    +import org.apache.flink.util.Collector
    +
    +/**
    +  * Connect data for left stream and right stream. Only use for left or right join without
    +  * non-equal predicates.
    +  *
    +  * @param leftType        the input type of left stream
    +  * @param rightType       the input type of right stream
    +  * @param resultType      the output type of join
    +  * @param genJoinFuncName the function code without any non-equi condition
    +  * @param genJoinFuncCode the function name without any non-equi condition
    +  * @param isLeftJoin      the type of join, whether it is the type of left join
    +  * @param queryConfig     the configuration for the query to generate
    +  */
    +class NonWindowLeftRightJoin(
    +    leftType: TypeInformation[Row],
    +    rightType: TypeInformation[Row],
    +    resultType: TypeInformation[CRow],
    +    genJoinFuncName: String,
    +    genJoinFuncCode: String,
    +    isLeftJoin: Boolean,
    +    queryConfig: StreamQueryConfig)
    +  extends NonWindowOuterJoin(
    +    leftType,
    +    rightType,
    +    resultType,
    +    genJoinFuncName,
    +    genJoinFuncCode,
    +    isLeftJoin,
    +    queryConfig) {
    +
    +  override def open(parameters: Configuration): Unit = {
    +    super.open(parameters)
    +    val joinType = if (isLeftJoin) "Left" else "Right"
    +    LOG.debug(s"Instantiating NonWindow${joinType}OuterJoin")
    +  }
    +
    +  /**
    +    * Puts or Retract an element from the input stream into state and search the other state to
    +    * output records meet the condition. The input row will be preserved and appended with null, if
    +    * there is no match. Records will be expired in state if state retention time has been
    +    * specified.
    +    */
    +  override def processElement(
    +      value: CRow,
    +      ctx: CoProcessFunction[CRow, CRow, CRow]#Context,
    +      out: Collector[CRow],
    +      timerState: ValueState[Long],
    +      currentSideState: MapState[Row, JTuple2[Long, Long]],
    +      otherSideState: MapState[Row, JTuple2[Long, Long]],
    +      recordFromLeft: Boolean): Unit = {
    +
    +    val inputRow = value.row
    +    val (curProcessTime, _) = updateCurrentSide(value, ctx, timerState, currentSideState)
    +
    +    cRowWrapper.reset()
    +    cRowWrapper.setCollector(out)
    +    cRowWrapper.setChange(value.change)
    +    cRowWrapper.setEmitCnt(0)
    --- End diff --
    
    Remove this line.


---