You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/05 07:59:55 UTC

[GitHub] [cloudstack-primate] utchoang opened a new pull request #324: Create new view component for Tree Domain

utchoang opened a new pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-645161973


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-644576664


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] utchoang commented on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-645114585


   @rhtyd  Thank you for the feedback. I have edited the following: When navigating from a different view, I will use a view like AutogenView (bellow image). 
   ![image](https://user-images.githubusercontent.com/13766648/84849375-4f89fd80-b07f-11ea-8601-c082e7531b64.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-644575911


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-633821970


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-639269451


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/324 (JID-1976)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-639264088






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] utchoang commented on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
utchoang commented on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-624473727


   Hi @rhytd. I completed fixed it. Please review and let me know your comments.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-644584170


   @utchoang can you address following:
   - Navigation from a different view does not show the domain tab with info card and comments (to reproduce goto account and click on domain "ROOT" for example)
   ![Screenshot from 2020-06-16 12-50-30](https://user-images.githubusercontent.com/95203/84743836-1c3c6580-afd0-11ea-88c7-441c0abe0860.png)
   - When navigating from a different view, it does not show/select the domain (use primate-qa server, go to accounts tab and say select "ROOT/saml" domain, on the left side of the tree-view still the "ROOT"domain is selected)
   - Perhaps for the resource view we can still use autogen-view but use the new component only for listView; for example when selecting a domain, we can show the view like:
   ![Screenshot from 2020-06-16 12-53-50](https://user-images.githubusercontent.com/95203/84744122-73423a80-afd0-11ea-84dc-1b170e2ccab4.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-645162141


   @rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-639263549


   @blueorangutan package


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-644580672


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/324 (JID-2010)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd removed a comment on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
rhtyd removed a comment on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-638048419


   @utchoang can you merge the conflict, thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] utchoang edited a comment on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-624473727


   Hi @rhtyd. I completed fixed it. Please review and let me know your comments.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd merged pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-633822345






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-645164670


   Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
   QA: http://primate-qa.cloudstack.cloud:8080/client/pr/324 (JID-2022)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-632914329


   @utchoang can you rebase against latest master, check/fix the conflict and the feature? Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-638048234


   @utchoang can you merge the conflict, thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [cloudstack-primate] rhtyd commented on pull request #324: Create new view component for Tree Domain

Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #324:
URL: https://github.com/apache/cloudstack-primate/pull/324#issuecomment-638048419


   @utchoang can you merge the conflict, thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org