You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2019/05/22 15:10:00 UTC

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests 

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13402


Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................

IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

"hive -e SQL..." without further parameters no longer works
when USE_CDP_HIVE=true (it doesn't establish a connection).
Some tests used this to load data.

part2: there were some places that still called hive without
a beeline connection.

Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
---
M tests/metadata/test_views_compatibility.py
M tests/query_test/test_scanners.py
2 files changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/13402/1
-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has removed a vote on this change.

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 7:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4313/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 May 2019 09:44:15 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13402/2/testdata/workloads/functional-query/queries/QueryTest/views-compatibility-hive2-only.test
File testdata/workloads/functional-query/queries/QueryTest/views-compatibility-hive2-only.test:

http://gerrit.cloudera.org:8080/#/c/13402/2/testdata/workloads/functional-query/queries/QueryTest/views-compatibility-hive2-only.test@19
PS2, Line 19: select /*+ MAPJOIN(alltypestiny) */ count(*) from
why does this not work in Hive 3? Seems like we should add some comment in the python file that indicates why we expect different behavior



-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 May 2019 04:44:17 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 7: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 May 2019 15:08:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 2: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13402/2/tests/metadata/test_views_compatibility.py
File tests/metadata/test_views_compatibility.py:

http://gerrit.cloudera.org:8080/#/c/13402/2/tests/metadata/test_views_compatibility.py@81
PS2, Line 81:   
nit: needs +2 indentation


http://gerrit.cloudera.org:8080/#/c/13402/2/tests/metadata/test_views_compatibility.py@84
PS2, Line 84:         unique_database)
nit: needs +2 indentation



-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 May 2019 19:39:01 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13402

to look at the new patch set (#2).

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................

IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

"hive -e SQL..." without further parameters no longer works
when USE_CDP_HIVE=true (it doesn't establish a connection).
Some tests used this to load data.

part2: there were some places that still called hive without
a beeline connection.

I had to break up views-compatibility.test for the different versions
of Hive.

Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
---
A testdata/workloads/functional-query/queries/QueryTest/views-compatibility-hive2-only.test
A testdata/workloads/functional-query/queries/QueryTest/views-compatibility-hive3-only.test
M testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test
M tests/metadata/test_views_compatibility.py
M tests/query_test/test_scanners.py
5 files changed, 58 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/13402/2
-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 5: Verified+1

Build failure was a maven issue in dockerised tests. The newly added/modified tests passed, so going to override it.


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 May 2019 23:46:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 6: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4311/


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 May 2019 08:06:30 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/3328/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 May 2019 16:12:03 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13402/2/testdata/workloads/functional-query/queries/QueryTest/views-compatibility-hive2-only.test
File testdata/workloads/functional-query/queries/QueryTest/views-compatibility-hive2-only.test:

http://gerrit.cloudera.org:8080/#/c/13402/2/testdata/workloads/functional-query/queries/QueryTest/views-compatibility-hive2-only.test@19
PS2, Line 19: # in views" is resolved.
> why does this not work in Hive 3? Seems like we should add some comment in 
Seems like a Hive bug to me, filed HIVE-21782 and added TODO.



-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 May 2019 11:56:30 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Todd Lipcon, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13402

to look at the new patch set (#3).

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................

IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

"hive -e SQL..." without further parameters no longer works
when USE_CDP_HIVE=true (it doesn't establish a connection).
Some tests used this to load data.

part2: there were some places that still called hive without
a beeline connection.

I had to break up views-compatibility.test for the different versions
of Hive.

Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
---
A testdata/workloads/functional-query/queries/QueryTest/views-compatibility-hive2-only.test
A testdata/workloads/functional-query/queries/QueryTest/views-compatibility-hive3-only.test
M testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test
M tests/metadata/test_views_compatibility.py
M tests/query_test/test_scanners.py
5 files changed, 60 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/13402/3
-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 5: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4303/


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 May 2019 23:02:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 1: Code-Review-1

Seems like Hive3 is more strict about SQL syntax. Need to modify some statements in views-compatibility.test


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 May 2019 16:28:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13402/2/tests/metadata/test_views_compatibility.py
File tests/metadata/test_views_compatibility.py:

http://gerrit.cloudera.org:8080/#/c/13402/2/tests/metadata/test_views_compatibility.py@157
PS2, Line 157: e
flake8: E722 do not use bare except'


http://gerrit.cloudera.org:8080/#/c/13402/2/tests/metadata/test_views_compatibility.py@157
PS2, Line 157:  
flake8: E261 at least two spaces before inline comment



-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 May 2019 17:33:39 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 1: Verified-1


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 May 2019 16:28:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13402/4/tests/metadata/test_views_compatibility.py
File tests/metadata/test_views_compatibility.py:

http://gerrit.cloudera.org:8080/#/c/13402/4/tests/metadata/test_views_compatibility.py@157
PS4, Line 157: e
flake8: E722 do not use bare except'


http://gerrit.cloudera.org:8080/#/c/13402/4/tests/metadata/test_views_compatibility.py@157
PS4, Line 157:  
flake8: E261 at least two spaces before inline comment



-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 May 2019 13:52:50 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................

IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

"hive -e SQL..." without further parameters no longer works
when USE_CDP_HIVE=true (it doesn't establish a connection).
Some tests used this to load data.

part2: there were some places that still called hive without
a beeline connection.

I had to break up views-compatibility.test for the different versions
of Hive.

Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Reviewed-on: http://gerrit.cloudera.org:8080/13402
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
A testdata/workloads/functional-query/queries/QueryTest/views-compatibility-hive2-only.test
A testdata/workloads/functional-query/queries/QueryTest/views-compatibility-hive3-only.test
M testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test
M tests/metadata/test_views_compatibility.py
M tests/query_test/test_scanners.py
5 files changed, 60 insertions(+), 31 deletions(-)

Approvals:
  Zoltan Borok-Nagy: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 8
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13402/2/tests/metadata/test_views_compatibility.py
File tests/metadata/test_views_compatibility.py:

http://gerrit.cloudera.org:8080/#/c/13402/2/tests/metadata/test_views_compatibility.py@81
PS2, Line 81:   
> nit: needs +2 indentation
Done


http://gerrit.cloudera.org:8080/#/c/13402/2/tests/metadata/test_views_compatibility.py@84
PS2, Line 84:           unique_database)
> nit: needs +2 indentation
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 May 2019 13:52:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 May 2019 17:35:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/3329/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 May 2019 18:30:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 1:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/3327/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 May 2019 15:23:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4303/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 May 2019 17:35:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 6:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4311/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 May 2019 23:47:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 1: Code-Review+2

Ouch, I only grepped for "hive, not 'hive before https://gerrit.cloudera.org/#/c/13282/


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 May 2019 16:06:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 6: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 6
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 May 2019 04:26:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/3352/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 May 2019 12:33:36 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 May 2019 13:57:46 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Todd Lipcon, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/13402

to look at the new patch set (#4).

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................

IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

"hive -e SQL..." without further parameters no longer works
when USE_CDP_HIVE=true (it doesn't establish a connection).
Some tests used this to load data.

part2: there were some places that still called hive without
a beeline connection.

I had to break up views-compatibility.test for the different versions
of Hive.

Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
---
A testdata/workloads/functional-query/queries/QueryTest/views-compatibility-hive2-only.test
A testdata/workloads/functional-query/queries/QueryTest/views-compatibility-hive3-only.test
M testdata/workloads/functional-query/queries/QueryTest/views-compatibility.test
M tests/metadata/test_views_compatibility.py
M tests/query_test/test_scanners.py
5 files changed, 60 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/02/13402/4
-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13402/3/tests/metadata/test_views_compatibility.py
File tests/metadata/test_views_compatibility.py:

http://gerrit.cloudera.org:8080/#/c/13402/3/tests/metadata/test_views_compatibility.py@157
PS3, Line 157: e
flake8: E722 do not use bare except'


http://gerrit.cloudera.org:8080/#/c/13402/3/tests/metadata/test_views_compatibility.py@157
PS3, Line 157:  
flake8: E261 at least two spaces before inline comment



-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 May 2019 11:52:12 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 7: Code-Review+2

Carrying +2. Trying to run GVO again since the failure was in an unrelated kudu test.


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 24 May 2019 09:45:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13402 )

Change subject: IMPALA-8524: part2: Avoid calling "hive" via command line in EE tests
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/3353/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/13402
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia45b64cc1da78190e6f239a5f462308d7fa56f4b
Gerrit-Change-Number: 13402
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 23 May 2019 14:35:10 +0000
Gerrit-HasComments: No