You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@stratos.apache.org by Pradeep Fernando <pr...@gmail.com> on 2014/01/14 05:58:05 UTC
I want to keep some jars in the stratos source.
Hi,
I'm working on some integration bits of the stratos console app. Im using
some of the third party apache licensed libraries there. However some of
the OOTB functionalists didnt match my requirement, hence i patched some of
them.
Is it okay to keep the patched jar files in the source for the moment. I
should be able to push those patches in to their main trunks and get a
release out before we hit the RC phase. At that point we can get rid of the
jar files in our sources..
wdyt ?
--Pradeep
Re: I want to keep some jars in the stratos source.
Posted by Pradeep Fernando <pr...@gmail.com>.
Hi Azeez,
I had to patch multiple jars, they were apached licensed and from wso2 code
base.
1. sso jagger module. It was missing some SAML2 related operation. I can't
get them from jaggery level without introducing java utils.
2. SSO related jars in identity. The idp-config.xml that we use to register
SPs using xml config does not support audience restrictions.
3. Jaggery POST method not working when empty replies happening.
I have no intention of keeping these jars till RC state in stratos 4.
I should be able to contribute these back to their original projects and
get dependency from them when we are in beta stage.
thanks,
--Pradeep
On Wed, Jan 15, 2014 at 11:56 PM, Noah Slater <ns...@apache.org> wrote:
> We shouldn't be keeping non-source files in the repository. (And we
> must never include non-source files in a release.)
>
> Including third-party code is pretty standard. Perhaps create a
> "vendor" directory, and import it there, along with any patches.
>
> Of course, the goal should be to get the patches upstream.
>
> On 15 January 2014 14:05, Afkham Azeez <af...@gmail.com> wrote:
> >
> >
> >
> > On Tue, Jan 14, 2014 at 10:28 AM, Pradeep Fernando <pr...@gmail.com>
> > wrote:
> >>
> >> Hi,
> >>
> >> I'm working on some integration bits of the stratos console app. Im
> using
> >> some of the third party apache licensed libraries there. However some
> of
> >> the OOTB functionalists didnt match my requirement, hence i patched
> some of
> >> them.
> >
> >
> > Can you explain what these libraries & and what are the changes that were
> > required? Perhaps there is a workaround which can be used to avoid
> patching
> > these jars.
> >
> >>
> >>
> >> Is it okay to keep the patched jar files in the source for the moment. I
> >> should be able to push those patches in to their main trunks and get a
> >> release out before we hit the RC phase. At that point we can get rid of
> the
> >> jar files in our sources..
> >>
> >> wdyt ?
> >>
> >> --Pradeep
> >>
> >>
> >
> >
> >
> > --
> > Afkham Azeez
> > Director of Architecture; WSO2, Inc.; http://wso2.com,
> > Member; Apache Software Foundation; http://www.apache.org/
> >
> > email: azeez@wso2.com cell: +94 77 3320919
> > blog: http://blog.afkham.org
> > twitter: http://twitter.com/afkham_azeez
> > linked-in: http://lk.linkedin.com/in/afkhamazeez
> >
> > Lean . Enterprise . Middleware
> >
>
>
>
> --
> Noah Slater
> https://twitter.com/nslater
>
--
Pradeep Fernando.
http://pradeepfernando.blogspot.com/
Re: I want to keep some jars in the stratos source.
Posted by Noah Slater <ns...@apache.org>.
We shouldn't be keeping non-source files in the repository. (And we
must never include non-source files in a release.)
Including third-party code is pretty standard. Perhaps create a
"vendor" directory, and import it there, along with any patches.
Of course, the goal should be to get the patches upstream.
On 15 January 2014 14:05, Afkham Azeez <af...@gmail.com> wrote:
>
>
>
> On Tue, Jan 14, 2014 at 10:28 AM, Pradeep Fernando <pr...@gmail.com>
> wrote:
>>
>> Hi,
>>
>> I'm working on some integration bits of the stratos console app. Im using
>> some of the third party apache licensed libraries there. However some of
>> the OOTB functionalists didnt match my requirement, hence i patched some of
>> them.
>
>
> Can you explain what these libraries & and what are the changes that were
> required? Perhaps there is a workaround which can be used to avoid patching
> these jars.
>
>>
>>
>> Is it okay to keep the patched jar files in the source for the moment. I
>> should be able to push those patches in to their main trunks and get a
>> release out before we hit the RC phase. At that point we can get rid of the
>> jar files in our sources..
>>
>> wdyt ?
>>
>> --Pradeep
>>
>>
>
>
>
> --
> Afkham Azeez
> Director of Architecture; WSO2, Inc.; http://wso2.com,
> Member; Apache Software Foundation; http://www.apache.org/
>
> email: azeez@wso2.com cell: +94 77 3320919
> blog: http://blog.afkham.org
> twitter: http://twitter.com/afkham_azeez
> linked-in: http://lk.linkedin.com/in/afkhamazeez
>
> Lean . Enterprise . Middleware
>
--
Noah Slater
https://twitter.com/nslater
Re: I want to keep some jars in the stratos source.
Posted by Afkham Azeez <af...@gmail.com>.
On Tue, Jan 14, 2014 at 10:28 AM, Pradeep Fernando <pr...@gmail.com>wrote:
> Hi,
>
> I'm working on some integration bits of the stratos console app. Im using
> some of the third party apache licensed libraries there. However some of
> the OOTB functionalists didnt match my requirement, hence i patched some of
> them.
>
Can you explain what these libraries & and what are the changes that were
required? Perhaps there is a workaround which can be used to avoid patching
these jars.
>
> Is it okay to keep the patched jar files in the source for the moment. I
> should be able to push those patches in to their main trunks and get a
> release out before we hit the RC phase. At that point we can get rid of the
> jar files in our sources..
>
> wdyt ?
>
> --Pradeep
>
>
>
--
*Afkham Azeez*
Director of Architecture; WSO2, Inc.; http://wso2.com,
*Member; Apache Software Foundation;
**http://www.apache.org/*<http://www.apache.org/>
*email: **azeez@wso2.com* <az...@wso2.com>
* cell: +94 77 3320919 blog: **http://blog.afkham.org*<http://blog.afkham.org>
*twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
* linked-in: **http://lk.linkedin.com/in/afkhamazeez
<http://lk.linkedin.com/in/afkhamazeez>*
*Lean . Enterprise . Middleware*
Re: I want to keep some jars in the stratos source.
Posted by Pradeep Fernando <pr...@gmail.com>.
.jar files. I dont want to branch external sources in to stratos. :)
On Tue, Jan 14, 2014 at 11:55 AM, Lahiru Sandaruwan <la...@wso2.com>wrote:
> Do you mean .jar files or source of those?
>
>
> On Tue, Jan 14, 2014 at 10:28 AM, Pradeep Fernando <pr...@gmail.com>wrote:
>
>> Hi,
>>
>> I'm working on some integration bits of the stratos console app. Im using
>> some of the third party apache licensed libraries there. However some of
>> the OOTB functionalists didnt match my requirement, hence i patched some of
>> them.
>>
>> Is it okay to keep the patched jar files in the source for the moment. I
>> should be able to push those patches in to their main trunks and get a
>> release out before we hit the RC phase. At that point we can get rid of the
>> jar files in our sources..
>>
>> wdyt ?
>>
>> --Pradeep
>>
>>
>>
>
>
> --
> --
> Lahiru Sandaruwan
> Software Engineer,
> Platform Technologies,
> WSO2 Inc., http://wso2.com
> lean.enterprise.middleware
>
> email: lahirus@wso2.com cell: (+94) 773 325 954
> blog: http://lahiruwrites.blogspot.com/
> twitter: http://twitter.com/lahirus
> linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146
>
>
--
Pradeep Fernando.
http://pradeepfernando.blogspot.com/
Re: I want to keep some jars in the stratos source.
Posted by Lahiru Sandaruwan <la...@wso2.com>.
Do you mean .jar files or source of those?
On Tue, Jan 14, 2014 at 10:28 AM, Pradeep Fernando <pr...@gmail.com>wrote:
> Hi,
>
> I'm working on some integration bits of the stratos console app. Im using
> some of the third party apache licensed libraries there. However some of
> the OOTB functionalists didnt match my requirement, hence i patched some of
> them.
>
> Is it okay to keep the patched jar files in the source for the moment. I
> should be able to push those patches in to their main trunks and get a
> release out before we hit the RC phase. At that point we can get rid of the
> jar files in our sources..
>
> wdyt ?
>
> --Pradeep
>
>
>
--
--
Lahiru Sandaruwan
Software Engineer,
Platform Technologies,
WSO2 Inc., http://wso2.com
lean.enterprise.middleware
email: lahirus@wso2.com cell: (+94) 773 325 954
blog: http://lahiruwrites.blogspot.com/
twitter: http://twitter.com/lahirus
linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146