[GitHub] [iceberg] marton-bod commented on a change in pull request #2119: Hive: Fix connection pool fails to connect to the Hive Metastore #1994

[GitBox <gi...@apache.org>]

marton-bod commented on a change in pull request #2119:
URL: https://github.com/apache/iceberg/pull/2119#discussion_r570953851



##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveClientPool.java
##########
@@ -83,6 +83,15 @@ protected HiveMetaStoreClient reconnect(HiveMetaStoreClient client) {
     return client;
   }
 
+  @Override
+  protected boolean isConnectionException(Exception e) {
+    if (super.isConnectionException(e) || (e != null && e instanceof MetaException &&
+        e.getMessage().contains("Got exception: org.apache.thrift.transport.TTransportException"))) {

Review comment:
       nit: can we just say:
   ```
   return super.isConnectionException(e) || (e != null && e instanceof MetaException &&
           e.getMessage().contains("Got exception: org.apache.thrift.transport.TTransportException"));
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org