[GitHub] [tinkerpop] xiazcy commented on a diff in pull request #1665: Gremlin-Go: Updated Docker Testing Set Up

[GitBox <gi...@apache.org>]

xiazcy commented on code in PR #1665:
URL: https://github.com/apache/tinkerpop/pull/1665#discussion_r878383829


##########
gremlin-go/docker/gremlin-server-integration.yaml:
##########
@@ -18,15 +18,16 @@
 host: 0.0.0.0
 port: 45940
 evaluationTimeout: 30000
+channelizer: org.apache.tinkerpop.gremlin.server.channel.UnifiedChannelizer
 graphs: {
-  graph: conf/tinkergraph-empty.properties,
-  immutable: conf/tinkergraph-empty.properties,
-  classic: conf/tinkergraph-empty.properties,
-  modern: conf/tinkergraph-empty.properties,
-  crew: conf/tinkergraph-empty.properties,
-  grateful: conf/tinkergraph-empty.properties,
-  sink: conf/tinkergraph-empty.properties,
-  tx: conf/neo4j-empty.properties
+  graph: scripts/tinkergraph-empty.properties,

Review Comment:
   Yes, this was intentional. The `tinkergraph-empty.properties` in the `conf` folder is for regular server set up, the `tinkergraph-empty.propertie` for testing was in the `test/scripts` folder. 
   It is more of an oversight before as the difference between them didn't have an impact in 3.5-dev, but for 3.6-dev, integration tests needed the `gremlin.tinkergraph.service` set up for server, so I switched to the `test/scripts` folder here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org