You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Nihal Jain (JIRA)" <ji...@apache.org> on 2019/01/21 06:39:00 UTC
[jira] [Updated] (HBASE-21749) RS UI may throw NPE and make
rs-status page inaccessible with multiwal and replication
[ https://issues.apache.org/jira/browse/HBASE-21749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nihal Jain updated HBASE-21749:
-------------------------------
Description:
Sometimes RS UI is unable to open as we get a NPE; This happens because {{shipper.getCurrentPath()}} may return null.
We should have a null check @ [ReplicationSource.java#L331|https://github.com/apache/hbase/blob/a2f6768acdc30b789c7cb8482b9f4352803f60a1/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L331]
{code:java}
Path currentPath = shipper.getCurrentPath();
try {
fileSize = getFileSize(currentPath);
} catch (IOException e) {
LOG.warn("Ignore the exception as the file size of HLog only affects the web ui", e);
fileSize = -1;
}{code}
was:
Sometimes RS UI is unable to open as we get a NPE; This happens because {{shipper.getCurrentPath()}} may return null.
We should have a null check @ [ReplicationSource.java#L331|https://github.com/apache/hbase/blob/a2f6768acdc30b789c7cb8482b9f4352803f60a1/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L331]
{code:java}
Path currentPath = shipper.getCurrentPath();
try {
fileSize = getFileSize(currentPath);
} catch (IOException e) {
LOG.warn("Ignore the exception as the file size of HLog only affects the web ui", e);
fileSize = -1;
}{code}
!0b8e95c7-6715-42bf-88d2-b2edc9215022.png!
> RS UI may throw NPE and make rs-status page inaccessible with multiwal and replication
> --------------------------------------------------------------------------------------
>
> Key: HBASE-21749
> URL: https://issues.apache.org/jira/browse/HBASE-21749
> Project: HBase
> Issue Type: Bug
> Components: Replication, UI
> Reporter: Nihal Jain
> Assignee: Nihal Jain
> Priority: Major
>
> Sometimes RS UI is unable to open as we get a NPE; This happens because {{shipper.getCurrentPath()}} may return null.
> We should have a null check @ [ReplicationSource.java#L331|https://github.com/apache/hbase/blob/a2f6768acdc30b789c7cb8482b9f4352803f60a1/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java#L331]
> {code:java}
> Path currentPath = shipper.getCurrentPath();
> try {
> fileSize = getFileSize(currentPath);
> } catch (IOException e) {
> LOG.warn("Ignore the exception as the file size of HLog only affects the web ui", e);
> fileSize = -1;
> }{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)