You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dependabot[bot] (via GitHub)" <gi...@apache.org> on 2025/07/01 09:48:11 UTC
[PR] chore(deps-dev): bump prettier from 3.5.3 to 3.6.2 in /superset-frontend [superset]
dependabot[bot] opened a new pull request, #33997:
URL: https://github.com/apache/superset/pull/33997
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): bump prettier from 3.5.3 to 3.6.2 in /superset-frontend [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on PR #33997:
URL: https://github.com/apache/superset/pull/33997#issuecomment-3104522808
Currently the prettier hook fixes many issues prior to linting which is great, is the eslint hook and its --fix as reliable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): bump prettier from 3.5.3 to 3.6.2 in /superset-frontend [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #33997:
URL: https://github.com/apache/superset/pull/33997#issuecomment-3109150870
Yes, we already have `prettier` integrated into ESLint as a plugin and from the attached video, you can see the pre-commit automatically fixes it, a `prettier`-related issue.
In addition, I'd like to remove the `prettier` hook as (1) it's [no longer maintained](https://github.com/pre-commit/mirrors-prettier) and (2) to consolidate `prettier` version to single source of`package.json` instead of upkeep in separate places.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): bump prettier from 3.5.3 to 3.6.2 in /superset-frontend [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on PR #33997:
URL: https://github.com/apache/superset/pull/33997#issuecomment-3023065573
By default, I don't review pull requests opened by bots. If you would like me to review this pull request anyway, you can request a review via the `/korbit-review` command in a comment.
[](e39766e1-ff79-442e-b8ce-dec321284e05)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): bump prettier from 3.5.3 to 3.6.2 in /superset-frontend [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber merged PR #33997:
URL: https://github.com/apache/superset/pull/33997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps-dev): bump prettier from 3.5.3 to 3.6.2 in /superset-frontend [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber commented on PR #33997:
URL: https://github.com/apache/superset/pull/33997#issuecomment-3103387992
We already have `eslint` added as local pre-commit hooks, in which they already integrate with `prettier`
Having a separate `prettier` commit hook would be pretty extraneous, imo.
The functionality is still intact, evidenced in below clip.
https://github.com/user-attachments/assets/cca6fc0f-4886-4855-858a-71f18583cea7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org