You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Olivier Lamy (JIRA)" <ji...@codehaus.org> on 2012/11/28 19:07:13 UTC

[jira] (MNG-5389) AbstractMavenLifecycleParticipant need a afterSessionEnd

Olivier Lamy created MNG-5389:
---------------------------------

             Summary: AbstractMavenLifecycleParticipant need a afterSessionEnd
                 Key: MNG-5389
                 URL: https://jira.codehaus.org/browse/MNG-5389
             Project: Maven 2 & 3
          Issue Type: Bug
          Components: Plugins and Lifecycle
    Affects Versions: 3.0.4
            Reporter: Olivier Lamy


we don't have way to know the build end with AbstractMavenLifecycleParticipant.
So adding a method afterSessionEnd(MavenSession session) could help 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MNG-5389) AbstractMavenLifecycleParticipant need a afterSessionEnd

Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MNG-5389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=314595#comment-314595 ] 

Jason van Zyl commented on MNG-5389:
------------------------------------

Just for clarification the participant is meant to mutate the session, or projects within the session so there's no reason at that point to alter the session. Here's an example of getting hold of the event at the end of a session:

https://github.com/tesla/tesla-profiler/blob/master/src/main/java/io/tesla/lifecycle/profiler/LifecycleProfiler.java#L50
                
> AbstractMavenLifecycleParticipant need a afterSessionEnd
> --------------------------------------------------------
>
>                 Key: MNG-5389
>                 URL: https://jira.codehaus.org/browse/MNG-5389
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Plugins and Lifecycle
>    Affects Versions: 3.0.4
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>             Fix For: 3.1.1
>
>
> we don't have way to know the build end with AbstractMavenLifecycleParticipant.
> So adding a method afterSessionEnd(MavenSession session) could help 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MNG-5389) AbstractMavenLifecycleParticipant need a afterSessionEnd

Posted by "Jason van Zyl (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MNG-5389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=314594#comment-314594 ] 

Jason van Zyl commented on MNG-5389:
------------------------------------

You can already get this information by implementing an EventSpy. Are you just looking for the notice of successful end of build?
                
> AbstractMavenLifecycleParticipant need a afterSessionEnd
> --------------------------------------------------------
>
>                 Key: MNG-5389
>                 URL: https://jira.codehaus.org/browse/MNG-5389
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Plugins and Lifecycle
>    Affects Versions: 3.0.4
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>             Fix For: 3.1.1
>
>
> we don't have way to know the build end with AbstractMavenLifecycleParticipant.
> So adding a method afterSessionEnd(MavenSession session) could help 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MNG-5389) AbstractMavenLifecycleParticipant need a afterSessionEnd

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/MNG-5389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy updated MNG-5389:
------------------------------

    Fix Version/s: 3.1.1
    
> AbstractMavenLifecycleParticipant need a afterSessionEnd
> --------------------------------------------------------
>
>                 Key: MNG-5389
>                 URL: https://jira.codehaus.org/browse/MNG-5389
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Plugins and Lifecycle
>    Affects Versions: 3.0.4
>            Reporter: Olivier Lamy
>             Fix For: 3.1.1
>
>
> we don't have way to know the build end with AbstractMavenLifecycleParticipant.
> So adding a method afterSessionEnd(MavenSession session) could help 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MNG-5389) AbstractMavenLifecycleParticipant need a afterSessionEnd

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/MNG-5389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy reassigned MNG-5389:
---------------------------------

    Assignee: Olivier Lamy
    
> AbstractMavenLifecycleParticipant need a afterSessionEnd
> --------------------------------------------------------
>
>                 Key: MNG-5389
>                 URL: https://jira.codehaus.org/browse/MNG-5389
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Plugins and Lifecycle
>    Affects Versions: 3.0.4
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>             Fix For: 3.1.1
>
>
> we don't have way to know the build end with AbstractMavenLifecycleParticipant.
> So adding a method afterSessionEnd(MavenSession session) could help 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MNG-5389) AbstractMavenLifecycleParticipant need a afterSessionEnd

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MNG-5389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=314609#comment-314609 ] 

Olivier Lamy commented on MNG-5389:
-----------------------------------

Thanks but I know EvenSpy.
My use case is an AbstractMavenLifecycleParticipant which connect to external resources to mutate session.
And as it's done here I don't have any way to cleanup those external resources connections.
Sure I can implements both lifecycle participation and event spy or the legacy Disposable but I just found that a bit hackhish.

                
> AbstractMavenLifecycleParticipant need a afterSessionEnd
> --------------------------------------------------------
>
>                 Key: MNG-5389
>                 URL: https://jira.codehaus.org/browse/MNG-5389
>             Project: Maven 2 & 3
>          Issue Type: Bug
>          Components: Plugins and Lifecycle
>    Affects Versions: 3.0.4
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>             Fix For: 3.1.1
>
>
> we don't have way to know the build end with AbstractMavenLifecycleParticipant.
> So adding a method afterSessionEnd(MavenSession session) could help 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira