You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/04 11:01:59 UTC
[GitHub] [pulsar] eolivelli opened a new pull request #12624: Functions: add -Dio.netty.tryReflectionSetAccessible=true to Java functions
eolivelli opened a new pull request #12624:
URL: https://github.com/apache/pulsar/pull/12624
### Motivation
In f0cbcb5f53d7 we added `-Dio.netty.tryReflectionSetAccessible=true` while starting Pulsar.
We are missing to set that property while starting Functions in PROCESS mode and in KUBERNETES mode.
`io.netty.tryReflectionSetAccessible` allows Netty to do its own management of Direct memory on JDK9+.
### Modifications
Add `-Dio.netty.tryReflectionSetAccessible=true` to the command line while launching the Java function process on the Functions Worker machine or in Kubernetes
### Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #12624: Functions: add -Dio.netty.tryReflectionSetAccessible=true to Java functions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12624:
URL: https://github.com/apache/pulsar/pull/12624#issuecomment-960651729
@eolivelli:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli merged pull request #12624: Functions: add -Dio.netty.tryReflectionSetAccessible=true to Java functions
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #12624:
URL: https://github.com/apache/pulsar/pull/12624
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org