[GitHub] [lucene] uschindler commented on a diff in pull request #12293: Capture build scans on ge.apache.org to benefit from deep build insights

["uschindler (via GitHub)" <gi...@apache.org>]

uschindler commented on code in PR #12293:
URL: https://github.com/apache/lucene/pull/12293#discussion_r1200427420


##########
gradle/ge.gradle:
##########
@@ -0,0 +1,26 @@
+def isGithubActions = System.getenv('GITHUB_ACTIONS') != null
+def isJenkins = System.getenv('JENKINS_URL') != null
+def isCI = isGithubActions || isJenkins

Review Comment:
   we already have a global variable to detect CI builds:
   https://github.com/apache/lucene/blob/8a602b5063d2154bf1ffa7ddb2a13a313cd954e0/gradle/globals.gradle#L153-L156



##########
gradle/ge.gradle:
##########
@@ -0,0 +1,26 @@
+def isGithubActions = System.getenv('GITHUB_ACTIONS') != null
+def isJenkins = System.getenv('JENKINS_URL') != null
+def isCI = isGithubActions || isJenkins
+
+gradleEnterprise {
+    server = "https://ge.apache.org"
+    buildScan {
+        capture { taskInputFiles = true }
+        uploadInBackground = !isCI
+        publishAlways()
+        publishIfAuthenticated()
+        obfuscation {
+            ipAddresses { addresses -> addresses.collect { address -> "0.0.0.0"} }
+        }
+    }
+}
+
+buildCache {

Review Comment:
   There are strong objections to enable the build cache of Gradle. It is explicitely disabled in our properties files.
   
   So please remove that!



##########
gradle/ge.gradle:
##########
@@ -0,0 +1,26 @@
+def isGithubActions = System.getenv('GITHUB_ACTIONS') != null
+def isJenkins = System.getenv('JENKINS_URL') != null
+def isCI = isGithubActions || isJenkins
+
+gradleEnterprise {
+    server = "https://ge.apache.org"

Review Comment:
   We also have Jenkins servers outside of Apache's infra. Those should not use this plugin!? I don't know if those have access.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org