You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/13 07:31:57 UTC

[GitHub] [spark] grundprinzip commented on a diff in pull request #38218: [SPARK-40587][CONNECT][FOLLOW] Make sure python client support select *

grundprinzip commented on code in PR #38218:
URL: https://github.com/apache/spark/pull/38218#discussion_r994262980


##########
python/pyspark/sql/connect/plan.py:
##########
@@ -319,9 +325,9 @@ def __init__(
 
     def _convert_measure(
         self, m: MeasureType, session: Optional["RemoteSparkSession"]
-    ) -> proto.Aggregate.Measure:
+    ) -> proto.Aggregate.AggregateFunction:

Review Comment:
   how did this not break before in the mypy checks?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org