You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/03/29 12:57:22 UTC
[GitHub] [cordova-plugin-inappbrowser] NiklasMerz opened a new pull request #861: fix(android): add space between default useragent and custom AppendUserAgent
NiklasMerz opened a new pull request #861:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/861
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
cordova-android adds a space between the default user agent and the custom one
(https://github.com/apache/cordova-android/blob/c144c0811249e22f91253ef919cc767f892a8fdf/framework/src/org/apache/cordova/engine/SystemWebViewEngine.java#L214) and the InAppBrowser does not. If a user/applications expect them to be equal this could cause an error.
### Description
<!-- Describe your changes in detail -->
With this change cordova-androids and the IAB user agent are exactly the same.
### Testing
<!-- Please describe in detail how you tested your changes. -->
Manual testing, no tests for useragent found
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [ ] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [ ] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-plugin-inappbrowser] NiklasMerz merged pull request #861: fix(android): add space between default useragent and custom AppendUserAgent
Posted by GitBox <gi...@apache.org>.
NiklasMerz merged pull request #861:
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org