You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "jihuayu (via GitHub)" <gi...@apache.org> on 2026/10/16 09:34:58 UTC
[I] Use the correct slot in the cluster-reset migration test [kvrocks]
jihuayu opened a new issue, #3687:
URL: https://github.com/apache/kvrocks/issues/3687
TestClusterReset/cannot_reset_cluster_if_the_db_is_migrating_the_slot migrates slot 2, but inserts its slowdown data into my-list, which hashes to slot 3491.
The data therefore does not delay the migration being tested. Migration can finish between the status check and RESET, which then reports “database is not empty” instead of “migrating slot”.
Use a key that hashes to the target slot and assert its CLUSTER KEYSLOT result before starting migration. Keep the assertion that RESET is rejected specifically because migration is active.
CI: https://github.com/apache/kvrocks/actions/runs/38868187280/job/116866054101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Use the correct slot in the cluster-reset migration test [kvrocks]
Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk closed issue #3687: Use the correct slot in the cluster-reset migration test
URL: https://github.com/apache/kvrocks/issues/3687
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Use the correct slot in the cluster-reset migration test [kvrocks]
Posted by "Roshan1299 (via GitHub)" <gi...@apache.org>.
Roshan1299 commented on issue #3687:
URL: https://github.com/apache/kvrocks/issues/3687#issuecomment-6231823282
Hi @jihuayu , I'd like to work on this, could you assign it to me? I checked the hashing: `my-list` is CRC16 slot 3491, while the test migrates slot 2 (`cluster_test.go` around line 575), so the 1 KB-batch, rate-limited migration isn't slowed by that data at all. I'd switch the list to a hash-tagged key that lands in slot 2 (for example `my-list-{sd7}`), assert `CLUSTER KEYSLOT` returns 2 before starting the migration, and keep the "Can't reset cluster while migrating slot" assertion as it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org